Obsolete iOS Compatibility AccessibilityExtensions#27593
Merged
jfversluis merged 2 commits intonet10.0from Feb 7, 2025
Merged
Conversation
jfversluis
added
platform/ios
area-controls-general
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Controls/src/Core/Compatibility/iOS/Extensions/AccessibilityExtensions.cs:94
- [nitpick] The parameter name '_defaultAccessibilityLabel' is not consistent with naming conventions. It should be renamed to 'defaultAccessibilityLabel'.
public static string SetAccessibilityLabel(this UIBarItem Control, Element Element, string _defaultAccessibilityLabel = null)
jsuarezruiz
approved these changes
Feb 6, 2025
rmarinho
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Resolve TODOs in code to obsolete the iOS compatibility AccessibilityExtensions.
Issues Fixed
Contributes to #8989