Closed
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 25 out of 28 changed files in this pull request and generated 2 comments.
Files not reviewed (3)
- src/Controls/docs/Microsoft.Maui.Controls/XmlnsDefinitionAttribute.xml: Language not supported
- src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Shipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/net/PublicAPI.Shipped.txt: Language not supported
| /// <include file="../../docs/Microsoft.Maui.Controls/XmlnsDefinitionAttribute.xml" path="//Member[@MemberName='AssemblyName']/Docs/*" /> | ||
| public string AssemblyName { get; set; } | ||
| //TODO we need an analyzer to check before runtime | ||
| if (target == "http://schemas.microsoft.com/winfx/2009/xaml" || target == "http://schemas.microsoft.com/winfx/2006/xaml") |
There was a problem hiding this comment.
The XmlnsDefinitionAttribute constructor now uses a 'target' parameter instead of 'clrNamespace', which is a breaking change. Please verify that all consumers are updated accordingly and that the documentation and tests reflect this change.
StephaneDelcroix
force-pushed
the
dev/stdelc/xmlnsaggregation
branch
from
21c132f to
2856e87
Compare
StephaneDelcroix
force-pushed
the
dev/stdelc/xmlnsaggregation
branch
2 times, most recently
from
6de9a5d to
ec71e64
Compare
Allow aggregating multiple xmlns into a single new global http://schemas.microsoft.com/dotnet/maui/global using XmlnsDefinition attribute, like this ```csharp [assembly: XmlnsDefinition("http://schemas.microsoft.com/dotnet/maui/global", "http://schemas.microsoft.com/dotnet/2021/maui")] ``` the x: xmlns can not be aggregated, as it serves important purposes for the parsers this also brings #28090 to fix #28150 - fixes #28150 - fixes #28843 - closes #28090
StephaneDelcroix
force-pushed
the
dev/stdelc/xmlnsaggregation
branch
from
08282fd to
b3cd16c
Compare
Contributor
Author
|
closing in favour of #29579 |
github-project-automation
bot
moved this from Ready To Review
to Done
in MAUI SDK Ongoing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Allow aggregating multiple xmlns into a single new global http://schemas.microsoft.com/dotnet/maui/global using XmlnsDefinition attribute, like this
the x: xmlns can not be aggregated, as it serves important purposes for the parsers
this also brings #28090 to fix #28150
It uses a source generator, so this change is transparent to anyone consuming maui XAML, including tooling
Issues Fixed