Skip to content

[iOS] SwipeView Closes when Content Changes - fix#29088

Merged
PureWeen merged 2 commits intodotnet:inflight/currentfrom
kubaflo:fix-29086
Jun 24, 2025
Merged

[iOS] SwipeView Closes when Content Changes - fix#29088
PureWeen merged 2 commits intodotnet:inflight/currentfrom
kubaflo:fix-29086

Conversation

@kubaflo
Copy link
Copy Markdown
Contributor

@kubaflo kubaflo commented Apr 19, 2025

Issues Fixed

Fixes #29086

Before After
Screen.Recording.2025-04-19.at.21.31.37.mov
Screen.Recording.2025-04-19.at.21.30.32.mov

Copilot AI review requested due to automatic review settings April 19, 2025 19:55
@kubaflo kubaflo requested a review from a team as a code owner April 19, 2025 19:55
@kubaflo kubaflo self-assigned this Apr 19, 2025
Copilot AI reviewed Apr 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where the SwipeView unexpectedly closes when its content changes on iOS. It implements a layout adjustment to reapply the swipe state, refactors the animation logic, and adds tests to verify the behavior.

  • Update MauiSwipeView to reapply swipe state during layout.
  • Refactor the swipe animation by extracting the frame-setting logic.
  • Add corresponding UI and automated tests for Issue29086.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
src/Core/src/Platform/iOS/MauiSwipeView.cs Adjusts layout and swipe animation logic to maintain the open state
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29086.cs Introduces a test case verifying that the SwipeView remains open
src/Controls/tests/TestCases.HostApp/Issues/Issue29086.xaml.cs Adds UI for the test case
Files not reviewed (1)
  • src/Controls/tests/TestCases.HostApp/Issues/Issue29086.xaml: Language not supported
Comments suppressed due to low confidence (2)

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29086.cs:24

  • [nitpick] Consider augmenting the screenshot verification with explicit assertions on the SwipeView state to better capture the intended non-closing behavior.
VerifyScreenshot();

src/Core/src/Platform/iOS/MauiSwipeView.cs:84

  • Calling Swipe(animated: false) from within LayoutSubviews could potentially trigger repeated layout passes. Please verify that this invocation does not lead to unintended recursive layout updates.
if (_isOpen)

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Apr 19, 2025
@jsuarezruiz
Copy link
Copy Markdown
Contributor

jsuarezruiz commented Apr 21, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Apr 21, 2025

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz
jsuarezruiz reviewed Apr 21, 2025
View reviewed changes
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29086.cs
App.SwipeLeftToRight("SwipeItem");
App.Click("AddButton");
App.Click("AddButton");
VerifyScreenshot();
Copy link
Copy Markdown
Contributor

@jsuarezruiz jsuarezruiz Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just trigger a build. Pending test snapshots in all the platforms.

@darrabam
Copy link
Copy Markdown

darrabam commented May 23, 2025

what’s the status of this? will the fix be rolled out in the coming release?

@darrabam
Copy link
Copy Markdown

darrabam commented May 27, 2025

@jfversluis could you please spare sometime to review and approve this?

@jfversluis jfversluis added this to the .NET 9 SR9 milestone Jun 23, 2025
@jfversluis
Copy link
Copy Markdown
Member

jfversluis commented Jun 23, 2025

/azp run MAUI-public

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 23, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@jfversluis
Copy link
Copy Markdown
Member

jfversluis commented Jun 23, 2025

@darrabam would you be able to test the result of this build following these instructions? https://github.com/dotnet/maui/wiki/Testing-PR-Builds

@darrabam
Copy link
Copy Markdown

darrabam commented Jun 23, 2025

@darrabam would you be able to test the result of this build following these instructions? https://github.com/dotnet/maui/wiki/Testing-PR-Builds

I haven’t tested it since the video above confirms the the fix, but sure I’ll give it a try following the instructions and test it on some edge cases too.

Thanks for pointing out the testing instructions!

@darrabam
Copy link
Copy Markdown

darrabam commented Jun 23, 2025

@kubaflo Thank you very much for the fix, it resolves the issue for Left & Top items, but not for Right & Bottom. I've updated the sample for you to test with:
https://github.com/darrabam/SwipeViewBugMAUI

2025-06-23-17-53-01.mp4

@PureWeen PureWeen changed the base branch from main to inflight/current June 24, 2025 17:21
@PureWeen PureWeen merged commit 90d1827 into dotnet:inflight/current Jun 24, 2025
17 checks passed
@kubaflo kubaflo mentioned this pull request Jun 25, 2025
Merged
@kubaflo
Copy link
Copy Markdown
Contributor Author

kubaflo commented Jun 25, 2025

@darrabam Thanks for letting me know! You're right. Here's a fix: #30182

PureWeen pushed a commit that referenced this pull request Jun 25, 2025
@kubaflo @PureWeen
[iOS] SwipeView Closes when Content Changes - fix (#29088)
9150a8e 
* [iOS] SwipeView Closes when Content Changes - fix

* Added snapshots
github-actions bot pushed a commit that referenced this pull request Jun 26, 2025
@kubaflo @PureWeen
[iOS] SwipeView Closes when Content Changes - fix (#29088)
ec6ee45 
* [iOS] SwipeView Closes when Content Changes - fix

* Added snapshots
PureWeen pushed a commit that referenced this pull request Jun 27, 2025
@kubaflo @PureWeen
[iOS] SwipeView Closes when Content Changes - fix (#29088)
5afa395 
* [iOS] SwipeView Closes when Content Changes - fix

* Added snapshots
PureWeen pushed a commit that referenced this pull request Jun 28, 2025
@kubaflo @PureWeen
[iOS] SwipeView Closes when Content Changes - fix (#29088)
fabc21f 
* [iOS] SwipeView Closes when Content Changes - fix

* Added snapshots
github-actions bot pushed a commit that referenced this pull request Jun 29, 2025
@kubaflo @PureWeen
[iOS] SwipeView Closes when Content Changes - fix (#29088)
39c4db6 
* [iOS] SwipeView Closes when Content Changes - fix

* Added snapshots
github-actions bot pushed a commit that referenced this pull request Jun 29, 2025
@kubaflo @PureWeen
[iOS] SwipeView Closes when Content Changes - fix (#29088)
c1c6e91 
* [iOS] SwipeView Closes when Content Changes - fix

* Added snapshots
github-actions bot pushed a commit that referenced this pull request Jul 1, 2025
@kubaflo @PureWeen
[iOS] SwipeView Closes when Content Changes - fix (#29088)
1c419a8 
* [iOS] SwipeView Closes when Content Changes - fix

* Added snapshots
github-actions bot pushed a commit that referenced this pull request Jul 2, 2025
@kubaflo @PureWeen
[iOS] SwipeView Closes when Content Changes - fix (#29088)
de752ea 
* [iOS] SwipeView Closes when Content Changes - fix

* Added snapshots
github-actions bot pushed a commit that referenced this pull request Jul 2, 2025
@kubaflo @PureWeen
[iOS] SwipeView Closes when Content Changes - fix (#29088)
0ceaa88 
* [iOS] SwipeView Closes when Content Changes - fix

* Added snapshots
github-actions bot pushed a commit that referenced this pull request Jul 8, 2025
@kubaflo @PureWeen
[iOS] SwipeView Closes when Content Changes - fix (#29088)
d27c94e 
* [iOS] SwipeView Closes when Content Changes - fix

* Added snapshots
github-actions bot pushed a commit that referenced this pull request Jul 8, 2025
@kubaflo @PureWeen
[iOS] SwipeView Closes when Content Changes - fix (#29088)
47274fd 
* [iOS] SwipeView Closes when Content Changes - fix

* Added snapshots
github-actions bot pushed a commit that referenced this pull request Jul 9, 2025
@kubaflo @rmarinho
[iOS] SwipeView Closes when Content Changes - fix (#29088)
4f9d09e 
* [iOS] SwipeView Closes when Content Changes - fix

* Added snapshots
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2025
jfversluis added a commit that referenced this pull request Nov 30, 2025
@jfversluis
[iOS] SwipeView Closes when Content Changes - right and bottom - fix (#…
ecd4513 
…30182)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!


### Description of Change

A correction to this pr #29088 that
fixes this comment
#29088 (comment)

### Issues Fixed

Fixes #29088 (comment)
Fixes #32033

|Before|After|
|--|--|
|<video
src="https://github.com/user-attachments/assets/d28d31b7-241a-43fd-832f-d8ac8abdf202"
width="300px"/>|<video
src="https://github.com/user-attachments/assets/c788d2d1-5227-48b3-a2ad-ae1093823057"
width="300px"/>|
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@jfversluis jfversluis jfversluis approved these changes

+1 more reviewer

@jsuarezruiz jsuarezruiz jsuarezruiz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kubaflo kubaflo

Labels

area-controls-swipeview SwipeView community ✨ Community Contribution platform/ios

Projects

None yet

Milestone

.NET 9 SR9

Development

Successfully merging this pull request may close these issues.

SwipeView Closes when Content Changes even with SwipeBehaviorOnInvoked="RemainOpen" (iOS only)

6 participants

@kubaflo @jsuarezruiz @darrabam @jfversluis @PureWeen