LineHeight and decorations for HTML Label - fix

[kubaflo]

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

Corrects mapping logic for LineHeight, TextDecorations, and CharacterSpacing to apply to HTML labels. Updates iOS handler to refresh these properties when TextType changes. Adds test case for Issue22197 to verify correct rendering of HTML labels with these properties.

Issues Fixed

Fixes #22193
Fixes #22197

Before	After

Before	After

[Copilot]

Pull Request Overview

This PR fixes issues with LineHeight, TextDecorations, and CharacterSpacing not being applied to HTML labels in .NET MAUI. The fix corrects the mapping logic to allow these properties to work with HTML text type labels, not just plain text labels.

• Updates the mapper conditions to check for FormattedTextSpans instead of plain text, allowing HTML labels to receive these style properties
• Modifies the iOS handler to refresh LineHeight, TextDecorations, and CharacterSpacing when TextType changes
• Adds comprehensive test case to verify the fix works correctly

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/Controls/src/Core/Label/Label.Mapper.cs	Updates mapping conditions from IsPlainText check to HasFormattedTextSpans check for LineHeight, TextDecorations, and CharacterSpacing
src/Controls/src/Core/Label/Label.iOS.cs	Adds refresh calls for LineHeight, TextDecorations, and CharacterSpacing when TextType changes in iOS handler
src/Controls/tests/TestCases.HostApp/Issues/Issue22197.xaml	Creates UI test page demonstrating HTML vs plain text labels with styling properties
src/Controls/tests/TestCases.HostApp/Issues/Issue22197.xaml.cs	Code-behind for the test page
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22197.cs	NUnit test implementation to verify the fix through screenshot verification

[Copilot]

The AutomationId 'label' is too generic and could conflict with other elements. Consider using a more specific identifier like 'htmlTextTypeLabel' to ensure uniqueness across all test cases.

[dotnet-policy-service]

Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[MartyIX]

This is how it looks like on Windows:

(For reference purposes)

[MartyIX]

This would exercise the line height feature more:

Suggested change

	</VerticalStackLayout>
	<!-- Exercise line heights less than 1. -->
	<Label BackgroundColor="Green" FontSize="20" Text="ÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑ"/>
	<Label BackgroundColor="Red" LineHeight="0.8" FontSize="20" Text="ÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑ"/>
	<Label BackgroundColor="Green" LineHeight="0.2" FontSize="20" Text="ÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑ"/>
	<Label BackgroundColor="Red" LineHeight="0.4" FontSize="20" Text="ÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑ"/>
	<Label BackgroundColor="Green" LineHeight="1.0" FontSize="20" Text="ÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑ"/>
	<Label BackgroundColor="Red" LineHeight="1.2" FontSize="20" Text="ÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑ"/>
	<Label BackgroundColor="Green" LineHeight="1.4" FontSize="20" Text="ÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑ"/>
	<Label BackgroundColor="Red" LineHeight="1.6" FontSize="20" Text="ÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑ"/>
	<Label BackgroundColor="Green" LineHeight="2.0" FontSize="20" Text="ÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑ"/>
	<Label BackgroundColor="Red" LineHeight="4.6" FontSize="20" Text="ÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑÑ"/>
	</VerticalStackLayout>

See comment #24520 (comment)

[kubaflo]

Hmmm but this pr is not about lineHeight in this sense. It is about the line Height for HTML labels

[MartyIX]

Good point. I moved the comment to #31219.

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 31202

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 31202"

[kubaflo]

/azp run maui-pr-uitests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kubaflo]

Code Review — PR #31202

Independent Assessment

What this changes: Corrects the mapper guard logic for LineHeight, TextDecorations, and CharacterSpacing on Label (Android + iOS). Previously these three properties were blocked for any non-plain-text label — including HTML labels — by the !IsPlainText(label) check. This PR narrows the guard to label.HasFormattedTextSpans, so the properties now correctly apply to HTML labels (TextType=Html) while still being skipped for FormattedText with spans. On iOS, MapFormatting is extended to also refresh these three properties when text type is HTML, since iOS attributed strings get rebuilt on text change.

Inferred motivation: Users setting LineHeight, TextDecorations, or CharacterSpacing on HTML labels see those properties silently ignored. The root cause is an overly broad guard that conflated "has formatted spans" with "is HTML."

Reconciliation with PR Narrative

Author claims: Fixes #22193 and #22197 — LineHeight/TextDecorations/CharacterSpacing not applied to HTML labels.
Agreement: Full agreement. The code does exactly what's described. The guard change is minimal, targeted, and logically correct.

Findings

⚠️ Stale comments — two comments now contradict the new behavior

src/Controls/src/Core/Label/Label.Mapper.cs:38 and :114 both still say:

// these are for properties that should only apply to plain text (not spans nor html)

After this change, these properties now do apply to HTML. Suggest updating to something like:

// these are for properties that should not apply to formatted text (spans)

⚠️ Missing newlines at end of file — all 3 new test files

Issue22197.xaml, Issue22197.xaml.cs, and the NUnit test Issue22197.cs all lack a trailing newline (\ No newline at end of file in the diff). Most files in the repo end with one.

💡 CI — baseline snapshots needed

The LineHeightWithHTMLLabelShouldWork screenshot test fails on all platforms with "Baseline snapshot not yet created." This is expected — the generated snapshot needs to be reviewed and committed. The other Label-lane failures (Issue22469, Issue23491, Issue23801) are pre-existing timeouts unrelated to this PR.

Devil's Advocate

• Could the mapper change break existing HTML labels that previously ignored these properties? In theory yes — an HTML label that happened to have LineHeight, TextDecorations, or CharacterSpacing set but relied on them being silently ignored would now render differently. In practice this is a bug fix: users setting those properties expect them to take effect, and the old behavior was the bug.
• Is the iOS MapFormatting change sufficient without a matching Android change? Yes. On Android, LineHeight/TextDecorations/CharacterSpacing are view-level properties (setLineSpacing, paint flags, letter spacing) that persist across text content changes. On iOS, they're encoded as NSAttributedString attributes that get rebuilt when HTML text is set, so they must be re-applied — hence the MapFormatting addition is iOS-only by design.

Verdict: LGTM

Confidence: high
Summary: The core logic change is correct and well-scoped — narrowing the guard from IsPlainText to HasFormattedTextSpans is the right fix. The iOS MapFormatting extension is necessary for the iOS attributed-string model. Two stale code comments and missing trailing newlines in the test files should be cleaned up before merge, and the screenshot baselines need to be generated from CI artifacts.

[kubaflo]

🟢 .NET MAUI Review - Approved

Expand Full Review - 6242a19 - LineHeight and decorations for HTML Label - fix

---

Independent Assessment

What this changes: Corrects the mapper guard logic for LineHeight, TextDecorations, and CharacterSpacing on Label (Android + iOS). Previously these three properties were blocked for any non-plain-text label — including HTML labels — by the !IsPlainText(label) check. This PR narrows the guard to label.HasFormattedTextSpans, so the properties now correctly apply to HTML labels (TextType=Html) while still being skipped for FormattedText with spans. On iOS, MapFormatting is extended to also refresh these three properties when text type is HTML, since iOS attributed strings get rebuilt on text change.

Inferred motivation: Users setting LineHeight, TextDecorations, or CharacterSpacing on HTML labels see those properties silently ignored. The root cause is an overly broad guard that conflated "has formatted spans" with "is HTML."

Reconciliation with PR Narrative

Author claims: Fixes #22193 and #22197 — LineHeight/TextDecorations/CharacterSpacing not applied to HTML labels.
Agreement: Full agreement. The code does exactly what's described. The guard change is minimal, targeted, and logically correct.

Findings

⚠️ Stale comments — two comments now contradict the new behavior

src/Controls/src/Core/Label/Label.Mapper.cs:38 and :114 both still say:

// these are for properties that should only apply to plain text (not spans nor html)

After this change, these properties now do apply to HTML. Suggest updating to something like:

// these are for properties that should not apply to formatted text (spans)

⚠️ Missing newlines at end of file — all 3 new test files

Issue22197.xaml, Issue22197.xaml.cs, and the NUnit test Issue22197.cs all lack a trailing newline (\ No newline at end of file in the diff). Most files in the repo end with one.

💡 CI — baseline snapshots needed

The LineHeightWithHTMLLabelShouldWork screenshot test fails on all platforms with "Baseline snapshot not yet created." This is expected — the generated snapshot needs to be reviewed and committed. The other Label-lane failures (Issue22469, Issue23491, Issue23801) are pre-existing timeouts unrelated to this PR.

Devil's Advocate

• Could the mapper change break existing HTML labels that previously ignored these properties? In theory yes — an HTML label that happened to have LineHeight, TextDecorations, or CharacterSpacing set but relied on them being silently ignored would now render differently. In practice this is a bug fix: users setting those properties expect them to take effect, and the old behavior was the bug.
• Is the iOS MapFormatting change sufficient without a matching Android change? Yes. On Android, LineHeight/TextDecorations/CharacterSpacing are view-level properties (setLineSpacing, paint flags, letter spacing) that persist across text content changes. On iOS, they're encoded as NSAttributedString attributes that get rebuilt when HTML text is set, so they must be re-applied — hence the MapFormatting addition is iOS-only by design.

Verdict: LGTM

Confidence: high
Summary: The core logic change is correct and well-scoped — narrowing the guard from IsPlainText to HasFormattedTextSpans is the right fix. The iOS MapFormatting extension is necessary for the iOS attributed-string model. Two stale code comments and missing trailing newlines in the test files should be cleaned up before merge, and the screenshot baselines need to be generated from CI artifacts.

[MauiBot]

🚦 Gate - Test Before and After Fix

📊 Expand Full Gate — 85c88f7 · Snapshots

---

Gate Result: ✅ PASSED

Platform: ANDROID · Base: main · Merge base: 720a9d4a

Test	Without Fix (expect FAIL)	With Fix (expect PASS)
🖥️ Issue22197 Issue22197	✅ FAIL — 671s	✅ PASS — 511s

🔴 Without fix — 🖥️ Issue22197: FAIL ✅ · 671s

  Determining projects to restore...
  Restored /home/vsts/work/1/s/src/BlazorWebView/src/Maui/Microsoft.AspNetCore.Components.WebView.Maui.csproj (in 9.37 sec).
  Restored /home/vsts/work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 9.32 sec).
  Restored /home/vsts/work/1/s/src/Controls/Foldable/src/Controls.Foldable.csproj (in 456 ms).
  Restored /home/vsts/work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 29 ms).
  Restored /home/vsts/work/1/s/src/Essentials/src/Essentials.csproj (in 34 ms).
  Restored /home/vsts/work/1/s/src/Core/src/Core.csproj (in 90 ms).
  Restored /home/vsts/work/1/s/src/Core/maps/src/Maps.csproj (in 42 ms).
  Restored /home/vsts/work/1/s/src/Controls/Maps/src/Controls.Maps.csproj (in 907 ms).
  Restored /home/vsts/work/1/s/src/Controls/src/Xaml/Controls.Xaml.csproj (in 55 ms).
  Restored /home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj (in 534 ms).
  1 of 11 projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0-android36.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0-android36.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0-android36.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Maps -> /home/vsts/work/1/s/artifacts/bin/Maps/Debug/net10.0-android36.0/Microsoft.Maui.Maps.dll
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-android36.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Foldable.dll
  Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-android36.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Maps.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Xaml.dll
  Controls.TestCases.HostApp -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Controls.TestCases.HostApp.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Maps.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Foldable.dll
  Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Xaml.dll
  Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Maps.dll
  Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.AspNetCore.Components.WebView.Maui.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:08:11.37
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
  Determining projects to restore...
  Restored /home/vsts/work/1/s/src/TestUtils/src/VisualTestUtils/VisualTestUtils.csproj (in 1.17 sec).
  Restored /home/vsts/work/1/s/src/Controls/tests/CustomAttributes/Controls.CustomAttributes.csproj (in 48 ms).
  Restored /home/vsts/work/1/s/src/TestUtils/src/VisualTestUtils.MagickNet/VisualTestUtils.MagickNet.csproj (in 5.15 sec).
  Restored /home/vsts/work/1/s/src/Controls/tests/TestCases.Android.Tests/Controls.TestCases.Android.Tests.csproj (in 6.4 sec).
  Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.Core/UITest.Core.csproj (in 2 ms).
  Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.Appium/UITest.Appium.csproj (in 2 ms).
  Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.NUnit/UITest.NUnit.csproj (in 328 ms).
  Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.Analyzers/UITest.Analyzers.csproj (in 2.07 sec).
  5 of 13 projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  Controls.CustomAttributes -> /home/vsts/work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  UITest.Core -> /home/vsts/work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
  UITest.Appium -> /home/vsts/work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
  UITest.NUnit -> /home/vsts/work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
  VisualTestUtils -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
  VisualTestUtils.MagickNet -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
  UITest.Analyzers -> /home/vsts/work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
  Controls.TestCases.Android.Tests -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
Test run for /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
/home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.10]   Discovering: Controls.TestCases.Android.Tests
[xUnit.net 00:00:00.29]   Discovered:  Controls.TestCases.Android.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
   NUnit3TestExecutor discovered 1 of 1 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 04/01/2026 22:39:01 FixtureSetup for Issue22197(Android)
>>>>> 04/01/2026 22:39:04 LineHeightWithHTMLLabelShouldWork Start
>>>>> 04/01/2026 22:39:10 LineHeightWithHTMLLabelShouldWork Stop
>>>>> 04/01/2026 22:39:10 Log types: logcat, bugreport, server
  Failed LineHeightWithHTMLLabelShouldWork [6 s]
  Error Message:
   VisualTestUtils.VisualTestFailedException : 
Snapshot different than baseline: LineHeightWithHTMLLabelShouldWork.png (6.10% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.

More info: https://aka.ms/visual-test-workflow

  Stack Trace:
     at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
   at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 123
   at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 477
   at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 309
   at Microsoft.Maui.TestCases.Tests.Issues.Issue22197.LineHeightWithHTMLLabelShouldWork() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22197.cs:line 18
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

NUnit Adapter 4.5.0.0: Test execution complete

Total tests: 1
     Failed: 1
Test Run Failed.
 Total time: 32.9312 Seconds

🟢 With fix — 🖥️ Issue22197: PASS ✅ · 511s

  Determining projects to restore...
  All projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0-android36.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0-android36.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0-android36.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Maps -> /home/vsts/work/1/s/artifacts/bin/Maps/Debug/net10.0-android36.0/Microsoft.Maui.Maps.dll
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-android36.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Xaml.dll
  Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Foldable.dll
  Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Maps.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-android36.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.TestCases.HostApp -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Controls.TestCases.HostApp.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Maps.dll
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Xaml.dll
  Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Foldable.dll
  Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Maps.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:06:35.95
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
  Determining projects to restore...
  All projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  Controls.CustomAttributes -> /home/vsts/work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13717716
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  VisualTestUtils -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
  UITest.Core -> /home/vsts/work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
  VisualTestUtils.MagickNet -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
  UITest.NUnit -> /home/vsts/work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
  UITest.Appium -> /home/vsts/work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
  UITest.Analyzers -> /home/vsts/work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
  Controls.TestCases.Android.Tests -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
Test run for /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
/home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.11]   Discovering: Controls.TestCases.Android.Tests
[xUnit.net 00:00:00.46]   Discovered:  Controls.TestCases.Android.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
   NUnit3TestExecutor discovered 1 of 1 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 04/01/2026 22:47:39 FixtureSetup for Issue22197(Android)
>>>>> 04/01/2026 22:47:41 LineHeightWithHTMLLabelShouldWork Start
>>>>> 04/01/2026 22:47:45 LineHeightWithHTMLLabelShouldWork Stop
  Passed LineHeightWithHTMLLabelShouldWork [3 s]
NUnit Adapter 4.5.0.0: Test execution complete

Test Run Successful.
Total tests: 1
     Passed: 1
 Total time: 21.7490 Seconds

📁 Fix files reverted (3 files)

• eng/pipelines/ci-copilot.yml
• src/Controls/src/Core/Label/Label.Mapper.cs
• src/Controls/src/Core/Label/Label.iOS.cs

New files (not reverted):

• github-merge-flow-release-11.jsonc

---

[MauiBot]

🤖 AI Summary

📊 Expand Full Review — 85c88f7 · Snapshots

---

🔍 Pre-Flight — Context & Validation

---

Issue: #22193 - LineHeight with HTML Label not working / #22197 - lineheight is broken
PR: #31202 - LineHeight and decorations for HTML Label - fix
Platforms Affected: Android, iOS
Files Changed: 2 implementation, 7 test (snapshots + XAML + UITest)

Key Findings

• MapLineHeight, MapTextDecorations, and MapCharacterSpacing in Label.Mapper.cs were guarded by !IsPlainText(label) which returns true for HTML labels (TextType.Html), causing an early return and skipping the property mapping entirely
• IsPlainText() returns false when either HasFormattedTextSpans OR TextType != TextType.Text — the original guard was overly broad, blocking HTML text labels from receiving these properties
• The fix changes the guard to only HasFormattedTextSpans, allowing HTML labels to pass through the guard and have the properties applied
• iOS Label.iOS.cs fix adds LineHeight, TextDecorations, and CharacterSpacing to the MapFormatting re-apply list when TextType == Html, so these properties also refresh when TextType changes
• Test uses a screenshot comparison (UITest) with two labels side-by-side (HTML and plain text) to visually confirm parity
• Open review comment: AutomationId="label" is too generic — should be more specific like "htmlTextTypeLabel"
• MartyIX suggested more comprehensive lineHeight test cases (various LineHeight values) but PR author correctly noted this PR's scope is HTML label fix, not general lineHeight testing

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #31202	Change !IsPlainText(label) → label.HasFormattedTextSpans in 3 mapper methods; add LineHeight/TextDecorations/CharacterSpacing to iOS MapFormatting	✅ PASSED (Gate)	Label.Mapper.cs, Label.iOS.cs	Clean minimal fix

---

🔧 Fix — Analysis & Comparison

---

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
1	try-fix (claude-opus-4.6)	label.IsSet() guard — apply LineHeight/TextDecorations/CharacterSpacing to HTML labels only when property explicitly set, following MapFont/MapTextColor pattern	✅ PASS	Label.Mapper.cs, Label.iOS.cs	Conservative; extra complexity without clear benefit
2	try-fix (claude-sonnet-4.6)	Non-default value check — label.LineHeight != -1.0, label.TextDecorations != None, label.CharacterSpacing != 0.0	✅ PASS	Label.Mapper.cs, Label.iOS.cs	Hardcoded magic default values; more fragile
3	try-fix (gpt-5.3-codex)	TextType-transition approach — trigger property refreshes from MapTextType when TextType==Html	✅ PASS	Label.Mapper.cs	Single-file fix; misses case where properties set before TextType
4	try-fix (gpt-5.4, gemini unavailable)	Rename IsPlainText() → ShouldSkipFormattingForSpans() with only HasFormattedTextSpans check	✅ PASS	Label.Mapper.cs, Label.iOS.cs	Functionally identical to PR's fix; just a rename
PR	PR #31202	Change !IsPlainText(label) → label.HasFormattedTextSpans in 3 mapper methods; add LineHeight/TextDecorations/CharacterSpacing to iOS MapFormatting	✅ PASSED (Gate)	Label.Mapper.cs, Label.iOS.cs	Simplest direct fix; minimal changes

Cross-Pollination

Model	Round	New Ideas?	Details
claude-opus-4.6	1	No	NO NEW IDEAS
claude-sonnet-4.6	1	No	NO NEW IDEAS
gpt-5.3-codex	1	Yes → No (R2)	Suggested HTML pipeline approach; withdrawn after analysis showed conflict with HTML/CSS
gpt-5.4	1	Yes → No (R2)	Same HTML pipeline suggestion; withdrawn after analysis

Exhausted: Yes
Selected Fix: PR's fix — Simplest and most direct. The !IsPlainText(label) → label.HasFormattedTextSpans change correctly identifies that the only reason to skip these properties is FormattedText spans, not HTML mode. Attempts 1-2 add unnecessary complexity. Attempt 3 is incomplete (misses initial render). Attempt 4 is functionally identical but adds a rename. PR fix is optimal.

---

📋 Report — Final Recommendation

---

✅ Final Recommendation: APPROVE

Phase Status

Phase	Status	Notes
Pre-Flight	✅ COMPLETE	2 issues (#22193, #22197), Android+iOS platforms
Gate	✅ PASSED	android — LineHeightWithHTMLLabelShouldWork passes with fix
Try-Fix	✅ COMPLETE	4 attempts, all 4 passing; cross-pollination exhausted in 2 rounds
Report	✅ COMPLETE

Summary

PR #31202 fixes LineHeight, TextDecorations, and CharacterSpacing not being applied to HTML labels (TextType="Html") on Android and iOS. The fix is minimal (6 lines changed across 2 implementation files) and surgically correct. Four independent fix attempts all passed, and cross-pollination across all models confirmed no better alternative exists. The PR's approach is the simplest of all candidates.

Root Cause

MapLineHeight, MapTextDecorations, and MapCharacterSpacing in Label.Mapper.cs were guarded by !IsPlainText(label). IsPlainText() returns false when either HasFormattedTextSpans is true OR TextType != TextType.Text — meaning HTML labels triggered the early return and never had these properties applied. The guard was semantically wrong: the intent was to skip span-based FormattedText, but HTML text got caught in the same exclusion. On iOS, MapFormatting also didn't refresh these properties when TextType changes to Html.

Fix Quality

Excellent. The change is:

• Correct: Replaces !IsPlainText(label) with label.HasFormattedTextSpans, which is exactly the right predicate — only skip when FormattedText spans are present, not for HTML
• Minimal: 3 one-line changes in the mapper, 3 added lines in the iOS formatter
• Consistent: IsPlainText() itself is still used in Label.iOS.cs (MapFormatting), so it remains without breaking existing callers
• Well-tested: UITest screenshot comparison for both HTML and plain text labels side-by-side

Minor issues identified:

1. AutomationId="label" is too generic (noted in review comment from copilot-pull-request-reviewer) — consider "htmlTextTypeLabel" for uniqueness
2. Missing newline at end of 3 new test files (Issue22197.xaml, Issue22197.xaml.cs, Issue22197.cs) — cosmetic only
3. Snapshots added for Android, Mac, Windows, and iOS-26 but not other iOS configurations — acceptable for screenshot tests

Try-Fix comparison: 4 independent attempts all passed but each was more complex than the PR's approach:

• Attempt 1 adds IsSet() guards (over-engineering)
• Attempt 2 hardcodes default values (fragile)
• Attempt 3 triggers from MapTextType (incomplete — misses initial render order)
• Attempt 4 is functionally identical with an unnecessary rename

The PR's simple 2-character guard replacement (!IsPlainText → HasFormattedTextSpans) is the optimal solution.

---