Skip to content

[XSG] trim color #32035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmarinho merged 1 commit into from
Oct 18, 2025
Merged

[XSG] trim color #32035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Controls/src/SourceGen/TypeConverters/ColorConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ internal class ColorConverter : ISGTypeConverter

public string Convert(string value, BaseNode node, ITypeSymbol toType, SourceGenContext context, LocalVariable? parentVar = null)
{
value = value.Trim();
if (ColorUtils.TryParse(value, out float red, out float green, out float blue, out float alpha))
{
var colorType = context.Compilation.GetTypeByMetadataName("Microsoft.Maui.Graphics.Color")!;
Expand Down
4 changes: 2 additions & 2 deletions src/Controls/tests/SourceGen.UnitTests/InitializeComponent/SimplifyOnPlatform.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public void Test()
x:Class="Test.TestPage">
<ContentPage.Resources>
<Style TargetType="Label" x:Key="style">
<Setter Property="TextColor" Value="Pink" />
<Setter Property="TextColor" Value="Pink " />
<Setter Property="IsVisible" Value="{OnPlatform Android=True, iOS=False}" />
</Style>
</ContentPage.Resources>
Expand Down Expand Up @@ -120,7 +120,7 @@ private partial void InitializeComponent()
setter.Property = ((global::Microsoft.Maui.Controls.IExtendedTypeConverter)new global::Microsoft.Maui.Controls.BindablePropertyConverter()).ConvertFromInvariantString("TextColor", xamlServiceProvider1) as global::Microsoft.Maui.Controls.BindableProperty;
#line default
#line 8 "{{testXamlFilePath}}"
setter.Value = "Pink";
setter.Value = "Pink ";
#line default
var setter2 = new global::Microsoft.Maui.Controls.Setter {Property = global::Microsoft.Maui.Controls.Label.TextColorProperty, Value = global::Microsoft.Maui.Graphics.Colors.Pink};
if (global::Microsoft.Maui.VisualDiagnostics.GetSourceInfo(setter2!) == null)
Expand Down
Loading