Skip to content

Add IntelliSense for testing properties#11029

Merged
JanKrivanek merged 7 commits intodotnet:mainfrom
Youssef1313:testing-completion
Jan 3, 2025
Merged

Add IntelliSense for testing properties#11029
JanKrivanek merged 7 commits intodotnet:mainfrom
Youssef1313:testing-completion

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Nov 25, 2024

@Youssef1313 Youssef1313 marked this pull request as ready for review November 25, 2024 12:01
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Global comments:

Some details like nuget packages, extensions included in profiles... are probably better not explained here but instead linked into doc so we could better handle changes and more complex details in the future.

You are sometimes wrapping values in single quotes sometimes not. It's probably better to always do it for property name, values and package names.

@YuliiaKovalova
Copy link
Member

Is it needed for VS functionality only?

@Youssef1313
Copy link
Member Author

Is it needed for VS functionality only?

@YuliiaKovalova Ideally, we want the completion to work fine everywhere. VS, VSCode, Rider. I have no idea if the XSD is respect only in VS or is respected everywhere. And if not respected everywhere, is there even a way to get it to work everywhere?

Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
@rainersigwald
Copy link
Member

Is it needed for VS functionality only?

Ideally, we want the completion to work fine everywhere. VS, VSCode, Rider. I have no idea if the XSD is respect only in VS or is respected everywhere. And if not respected everywhere, is there even a way to get it to work everywhere?

Today this only works in VS. Getting it to work everywhere is tracked by #1774.

@Youssef1313
Copy link
Member Author

@rainersigwald This is green now. Is it good to merge please?

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JanKrivanek I can't think of a reason not to take this to 17.13--is that still ok timeline-wise?

@Youssef1313
Copy link
Member Author

@rainersigwald @YuliiaKovalova @JanKrivanek Is this good to merge?

@JanKrivanek
Copy link
Member

It's good to go!

@Youssef1313 - did you have in mind any timeline of shipping this? Is early Feb with 17.14 Preview 1 fine?

@JanKrivanek JanKrivanek merged commit 5357f31 into dotnet:main Jan 3, 2025
@Youssef1313 Youssef1313 deleted the testing-completion branch January 3, 2025 11:56
@Youssef1313
Copy link
Member Author

I haven't planned a timeline with @Evangelink on this. I think it should be fine early Feb, but will double check.

@Evangelink
Copy link
Member

Sure, the earlier the better but this is absent for some time so it's not blocking anything. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IntelliSense support for MSTest.Sdk properties

5 participants