-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Replace OpenTelemetry with Microsoft.VisualStudio.Telemetry for VS #12843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@JanProvaznik please take a look if i didn't remove something extra |
JanProvaznik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it removes some reusability of behavior between framework and core
af884cf to
79f1712
Compare
…nto exp/telemetry
7b133a5 to
7ca2245
Compare
…nto exp/telemetry
…o exp/telemetry
JanProvaznik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good, please write down the scenarios you manually tested in the pr description so we have written down what this PR achieves and attest that experimental insertion succeeds in terms of perf ddrits (what I did for opentelemetry implementation was an experimental insertion that also flipped the feature to be always on and looked at perf ddrits)
…a/telemetry_spike
…v/ykovalova/telemetry_spike
8da8f95 to
924c0a3
Compare
a9235f1 to
4e6d0b3
Compare
Summary
This PR replaces the VS OpenTelemetry-based telemetry infrastructure with the simpler Microsoft.VisualStudio.Telemetry package, simplifying the telemetry implementation while maintaining the ability to collect build telemetry in Visual Studio scenarios.
Motivation
The VS OpenTelemetry integration introduced dependencies on many packages and made VS perf sad.
Notes
Telemetry collection relies on VS telemetry state - if it's enabled there, we collect data in msbuild.exe too