Skip to content

Simplify PR pool definitions #13330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rainersigwald wants to merge 2 commits into
base: main
Choose a base branch
from
+35 −30
Draft

Simplify PR pool definitions #13330

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0ac084
Centralize pool selection in CI pipeline variables
rainersigwald Mar 4, 2026
ce28af0
Use shared Linux pool config for multithreaded CI job
rainersigwald Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 35 additions & 30 deletions .vsts-dotnet-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ trigger:
- vs*

variables:
- template: /eng/common/templates/variables/pool-providers.yml
- ${{ if eq(variables['System.TeamProject'], 'DevDiv') }}:
- group: AzureDevOps-Artifact-Feeds-Pats
- name: cfsNugetWarnLevel
Expand All @@ -12,6 +13,25 @@ variables:
value: none
- name: NugetSecurityAnalysisWarningLevel
value: none
# Centralized pool configuration to avoid duplicating conditional blocks across jobs.
- ${{ if eq(variables['System.TeamProject'], 'public') }}:
- name: WindowsPoolName
value: $(DncEngPublicBuildPool)
- name: WindowsPoolDemands
value: ImageOverride -equals windows.vs2026preview.scout.amd64.open
- name: LinuxPoolName
value: $(DncEngPublicBuildPool)
- name: LinuxPoolDemands
value: ImageOverride -equals Build.Ubuntu.2204.Amd64.Open
- ${{ if ne(variables['System.TeamProject'], 'public') }}:
- name: WindowsPoolName
value: VSEng-MicroBuildVSStable
- name: WindowsPoolDemands
value: agent.os -equals Windows_NT
- name: LinuxPoolName
value: Azure Pipelines
- name: LinuxPoolDemands
value: ImageOverride -equals ubuntu-latest

jobs:
- job: CheckVersionBumpOnReleaseBranches
Expand Down Expand Up @@ -65,12 +85,8 @@ jobs:
coverageReportName: WindowsFullFrameworkCoverage
displayName: "Windows Full"
pool:
${{ if eq(variables['System.TeamProject'], 'public') }}:
name: NetCore-Public
demands: ImageOverride -equals windows.vs2026preview.scout.amd64.open
${{ if ne(variables['System.TeamProject'], 'public') }}:
name: VSEng-MicroBuildVSStable
demands: agent.os -equals Windows_NT
name: $(WindowsPoolName)
demands: $(WindowsPoolDemands)
timeoutInMinutes: 120
steps:
- template: azure-pipelines/check-documentation-only-change.yml
Expand Down Expand Up @@ -177,12 +193,8 @@ jobs:
coverageArtifactsDir: $(Build.SourcesDirectory)/CoverageStaging
coverageReportName: WindowsCoreCoverage
pool:
${{ if eq(variables['System.TeamProject'], 'public') }}:
name: NetCore-Public
demands: ImageOverride -equals windows.vs2026preview.scout.amd64.open
${{ if ne(variables['System.TeamProject'], 'public') }}:
name: VSEng-MicroBuildVSStable
demands: agent.os -equals Windows_NT
name: $(WindowsPoolName)
demands: $(WindowsPoolDemands)
timeoutInMinutes: 120
steps:
- template: azure-pipelines/check-documentation-only-change.yml
Expand Down Expand Up @@ -258,7 +270,11 @@ jobs:
- job: BootstrapMSBuildWithMTMode
displayName: "Linux Core Multithreaded Mode"
pool:
vmImage: 'ubuntu-latest'
${{ if eq(variables['System.TeamProject'], 'public') }}:
name: $(DncEngPublicBuildPool)
demands: ImageOverride -equals Build.Ubuntu.2204.Amd64.Open
${{ if ne(variables['System.TeamProject'], 'public') }}:
vmImage: 'ubuntu-latest'
timeoutInMinutes: 120
steps:
- template: azure-pipelines/check-documentation-only-change.yml
Expand Down Expand Up @@ -291,12 +307,8 @@ jobs:
coverageArtifactsDir: $(Build.SourcesDirectory)/CoverageStaging
coverageReportName: WindowsFullReleaseCoverage
pool:
${{ if eq(variables['System.TeamProject'], 'public') }}:
name: NetCore-Public
demands: ImageOverride -equals windows.vs2026preview.scout.amd64.open
${{ if ne(variables['System.TeamProject'], 'public') }}:
name: VSEng-MicroBuildVSStable
demands: agent.os -equals Windows_NT
name: $(WindowsPoolName)
demands: $(WindowsPoolDemands)
timeoutInMinutes: 120
steps:
- template: azure-pipelines/check-documentation-only-change.yml
Expand Down Expand Up @@ -377,11 +389,8 @@ jobs:
- job: CoreBootstrappedOnLinux
displayName: "Linux Core"
pool:
${{ if eq(variables['System.TeamProject'], 'public') }}:
name: NetCore-Public
demands: ImageOverride -equals Build.Ubuntu.2204.Amd64.Open
${{ if ne(variables['System.TeamProject'], 'public') }}:
vmImage: 'ubuntu-latest'
name: $(LinuxPoolName)
demands: $(LinuxPoolDemands)
steps:
- template: azure-pipelines/check-documentation-only-change.yml
- ${{ if eq(variables['System.TeamProject'], 'DevDiv') }}:
Expand Down Expand Up @@ -567,12 +576,8 @@ jobs:
variables:
onlyDocChanged: $[ dependencies.BootstrapMSBuildOnFullFrameworkWindows.outputs['CheckDocumentationOnlyChange.onlyDocChanged'] ]
pool:
${{ if eq(variables['System.TeamProject'], 'public') }}:
name: NetCore-Public
demands: ImageOverride -equals windows.vs2026preview.scout.amd64.open
${{ if ne(variables['System.TeamProject'], 'public') }}:
name: VSEng-MicroBuildVSStable
demands: agent.os -equals Windows_NT
name: $(WindowsPoolName)
demands: $(WindowsPoolDemands)
steps:
# Task to collect code coverage on Windows. Disabled by default due to being unstable and sometimes it stucks forever
# - task: DownloadPipelineArtifact@2
Expand Down
Loading