WinMDExp Migration#13682
Open
AlesProkop wants to merge 3 commits intodotnet:mainfrom
Open
Conversation
69 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This draft PR starts migrating the built-in WinMDExp task toward MSBuild’s multithreaded execution model. In the codebase, WinMDExp is a Windows-only ToolTask wrapper around winmdexp.exe, so the intended fit is to move path/process interactions onto TaskEnvironment-safe patterns.
Changes:
- Marks the .NET Framework
WinMDExptask with[MSBuildMultiThreadableTask]. - Updates
GenerateFullPathToTool()to use aTaskEnvironment-aware existence probe during SDK tool discovery. - Updates
SkipTaskExecution()to absolutize the input/output paths used for timestamp comparison.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13635
Context
Migrates
WinMDExpto the multithreaded task model so its path handling, environment access, andwinmdexp.exeprocesslaunch go through
TaskEnvironment.Changes Made
[MSBuildMultiThreadableTask]andIMultiThreadableTask.TaskEnvironment.GetAbsolutePath()before filesystem probes and toolexecution.
TaskEnvironment.GetEnvironmentVariable().winmdexp.exeprocess creation throughTaskEnvironment.GetProcessStartInfo().Testing