[Draft]: Introduce mode for project graph construction to load entire graph #13717
Draft
jeffkl wants to merge 1 commit intodotnet:mainfrom
Draft
[Draft]: Introduce mode for project graph construction to load entire graph #13717jeffkl wants to merge 1 commit intodotnet:mainfrom
jeffkl wants to merge 1 commit intodotnet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
Changes Made
Introduced a new
ProjectGraphOptionsstruct because project graph construction happens in a constructor and adding a new overload seemed like a worse design. This way we can add new options to the struct and not keep having to modify the constructor.In the new mode,
SetTargetFrameworkis ignored during graph construction and all outer and inner builds are evaluated. If the "full" graph was used for a build, it would technically over build, but this graph will be used by NuGet in for restore.Testing
Notes