Use LoggerMessageGenerator for core logging messages#9274
Closed
Meir017 wants to merge 1 commit intodotnet:mainfrom
Closed
Use LoggerMessageGenerator for core logging messages#9274Meir017 wants to merge 1 commit intodotnet:mainfrom
Meir017 wants to merge 1 commit intodotnet:mainfrom
Conversation
Update core logging messages to use LoggerMessageGenerator for logging. * Modify `src/Orleans.Core/Diagnostics/MessagingTrace.cs` to use LoggerMessageGenerator for logging instead of `LoggerMessage.Define`. * Modify `src/Orleans.Core/Manifest/ClientClusterManifestProvider.cs` to use LoggerMessageGenerator for logging instead of `logger.IsEnabled`. * Modify `src/Orleans.Core/Messaging/ClientMessageCenter.cs` to use LoggerMessageGenerator for logging instead of `logger.IsEnabled`. * Modify `src/Orleans.Core/Messaging/GatewayManager.cs` to use LoggerMessageGenerator for logging instead of `logger.IsEnabled`.
12 tasks
Member
|
How did you implement this, was there a tool which was used? If so, which |
Contributor
Author
@ReubenBond I tried using the github copilot workspace |
Member
Ok, great :) I will keep that in mind when reviewing. |
Contributor
There was a problem hiding this comment.
Copilot reviewed 6 out of 18 changed files in this pull request and generated no comments.
Files not reviewed (12)
- src/Orleans.Runtime/Lifecycle/SiloLifecycleSubject.cs: Evaluated as low risk
- src/Orleans.Runtime/Silo/Silo.cs: Evaluated as low risk
- src/Orleans.Runtime/Scheduler/ActivationTaskScheduler.cs: Evaluated as low risk
- src/Orleans.Runtime/Placement/PlacementService.cs: Evaluated as low risk
- src/Orleans.Runtime/Messaging/Gateway.cs: Evaluated as low risk
- src/Orleans.Runtime/Placement/Repartitioning/ActivationRepartitioner.MessageSink.cs: Evaluated as low risk
- src/Orleans.Core/Diagnostics/MessagingTrace.cs: Evaluated as low risk
- src/Orleans.Core/Manifest/ClientClusterManifestProvider.cs: Evaluated as low risk
- src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs: Evaluated as low risk
- src/Orleans.Runtime/Hosting/EndpointOptionsProvider.cs: Evaluated as low risk
- src/Orleans.Core/Messaging/ClientMessageCenter.cs: Evaluated as low risk
- src/Orleans.Runtime/Core/HostedClient.cs: Evaluated as low risk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update core logging messages to use LoggerMessageGenerator for logging.
src/Orleans.Core/Diagnostics/MessagingTrace.csto use LoggerMessageGenerator for logging instead ofLoggerMessage.Define.src/Orleans.Core/Manifest/ClientClusterManifestProvider.csto use LoggerMessageGenerator for logging instead oflogger.IsEnabled.src/Orleans.Core/Messaging/ClientMessageCenter.csto use LoggerMessageGenerator for logging instead oflogger.IsEnabled.src/Orleans.Core/Messaging/GatewayManager.csto use LoggerMessageGenerator for logging instead oflogger.IsEnabled.Microsoft Reviewers: Open in CodeFlow