Skip to content

Fix Consul CI tests by using compatible Consul version #9701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReubenBond merged 4 commits into from
Oct 2, 2025
Merged

Fix Consul CI tests by using compatible Consul version #9701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f25fa4a
Fix Consul key format to comply with allowed characters
Copilot Oct 1, 2025
c9e366b
Use custom encoding for Consul keys instead of URL encoding
Copilot Oct 1, 2025
70d51fe
Simplify encoding logic to handle both IPv4 and IPv6
Copilot Oct 1, 2025
9f357c1
Revert breaking changes and use older Consul version for tests
Copilot Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,15 +346,14 @@ jobs:
matrix:
provider: ["Consul"]
framework: [net8.0]
services:
consul:
image: hashicorp/consul
ports:
- 8500:8500
- 8600:8600/tcp
- 8600:8600/udp
steps:
- uses: actions/checkout@v4
- name: Start Consul
run: |
docker run -d --name consul -p 8500:8500 -p 8600:8600/tcp -p 8600:8600/udp \
hashicorp/consul:1.19 agent -dev -client=0.0.0.0
- name: Wait for Consul
run: sleep 5
- name: Setup .NET
uses: actions/setup-dotnet@v4
with:
Expand All @@ -372,6 +371,9 @@ jobs:
# [SuppressMessage("Microsoft.Security", "CSCAN0090:ConfigFile", Justification="Not a secret")]
# [SuppressMessage("Microsoft.Security", "CSCAN0220:DefaultPasswordContexts", Justification="Not a secret")]
ORLEANSCONSULCONNECTIONSTRING: "http://localhost:8500"
- name: Clean up Consul container
if: always()
run: docker rm -f consul
- name: Archive Test Results
if: always()
uses: actions/upload-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion src/Orleans.TestingHost/TestClusterBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ public static string CreateClusterId()
string prefix = "testcluster-";
int randomSuffix = Random.Shared.Next(1000);
DateTime now = DateTime.UtcNow;
string DateTimeFormat = @"yyyy-MM-dd\tHH-mm-ss";
string DateTimeFormat = @"yyyy-MM-dd-HH-mm-ss";
return $"{prefix}{now.ToString(DateTimeFormat, CultureInfo.InvariantCulture)}-{randomSuffix}";
}

Expand Down