Add VectorMax and Clamp to SVE microbenchmark#5042
Open
ylpoonlg wants to merge 3 commits intodotnet:mainfrom
Open
Add VectorMax and Clamp to SVE microbenchmark#5042ylpoonlg wants to merge 3 commits intodotnet:mainfrom
ylpoonlg wants to merge 3 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new SVE-focused microbenchmarks to the src/benchmarks/micro/sve suite to measure VectorMax and Clamp implementations on Arm64 + SVE-capable machines, enabling comparison between scalar, Vector128 (AdvSimd), and SVE approaches.
Changes:
- Introduce
VectorMaxbenchmark with Scalar, Vector128, and SVE implementations plus correctness verification. - Introduce
Clampbenchmark with Scalar, Vector128, and two SVE loop variants plus correctness verification.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/benchmarks/micro/sve/VectorMax.cs | New SVE benchmark for max value + index reduction across an array, with Scalar/Vector128/SVE variants. |
| src/benchmarks/micro/sve/Clamp.cs | New clamp-style benchmark comparing Scalar vs Vector128 and SVE implementations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| // Get the maximum element across the max vector. | ||
| short maxVal = AdvSimd.Arm64.MaxAcross(maxVec).ToScalar(); | ||
|
|
||
| // Find the first occurence (min index) of the max value. |
| // Get the maximum element across the max vector. | ||
| short maxVal = Sve.MaxAcross(maxVec).ToScalar(); | ||
|
|
||
| // Find the first occurence (min index) of the max value. |
| using System.Runtime.Intrinsics; | ||
| using System.Runtime.Intrinsics.Arm; | ||
| using BenchmarkDotNet.Attributes; | ||
| using BenchmarkDotNet.Extensions; |
| } | ||
|
|
||
| [Params(15, 127, 527, 10015)] | ||
| public short Size; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance Results
Run on Neoverse-V2
cc @dotnet/arm64-contrib @SwapnilGaikwad @LoopedBard3