Conversation
This addresses some feedback from #8762
jaredpar
commented
Jun 23, 2023
| @echo off | ||
| setlocal | ||
|
|
||
| set _args=-restore -build /p:_SelfContainedWasSpecified=true %* |
Member
Author
There was a problem hiding this comment.
The original code here was /p:TreatWarningsAsErros=true. This is intentionally being removed because it's redundant with the defaults for $warnAsError of build.ps1 and together it makes it hard to turn this off locally.
ryzngard
approved these changes
Jun 23, 2023
333fred
added a commit
to 333fred/razor
that referenced
this pull request
Jun 26, 2023
* upstream/main: (212 commits) Bump analyzer testing Clean up from previous PR (dotnet#8863) new zip idea Apply code review feedback powershell Apply suggestions from code review Fix test failures after resolving merge conflict More Update src/Razor/src/rzls/rzls.csproj fix container fix queue names another workaround Add ImmutableArray<T>.SelectAsArray(...) extension method Work around unsupported base image Return ImmutableArray<T> from GetClassifiedSpans() and GetTagHelperSpans() Add ItemCollection.TryGetValue(...) method Add ImmutableArray<T>.DrainToImmutable() extension method Fix version diff Rename extension method to match others Add `global::` prefix to default cshtml usings (dotnet#8857) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses some feedback from #8762