exposing SingleAssignmentDisposableValue and making it ICancelable#1630
Merged
idg10 merged 4 commits intodotnet:mainfrom Apr 19, 2023
Merged
exposing SingleAssignmentDisposableValue and making it ICancelable#1630idg10 merged 4 commits intodotnet:mainfrom
idg10 merged 4 commits intodotnet:mainfrom
Conversation
Collaborator
|
Are you sure we should make it implement If there were cases where generic methods imposed a constraint, it might be different, but Rx doesn't appear to do that anywhere. So I'm wondering if the reason this type was defined as not implementing |
It was pointed out by @idg10 that the ICancelable would promote accidental usages in scenarios that would result in the SingleAssignmentDisposableValue being boxed. I agree with that argument. As there's no real need to make it ICancelable I'm undoing that part of my change.
Contributor
Author
|
I agree with your argument. I'll refrain from making the SingleAssignmentDisposableValue implement ICancelable. |
idg10
approved these changes
Apr 19, 2023
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When implementing various things outside of this library like a custom IScheduler or a custom rx operator the SingleAssignmentDisposableValue can be quite useful. Since it is already well documented and it seams to me like it can't be used wrong, I'd like to make it public and make implement ICancelable also.
Would that be ok with you?
Also please let me know if I have to bump versions manually.