Add MakeTypesInternalAnalyzer by CollinAlpert · Pull Request #6820 · dotnet/roslyn-analyzers

CollinAlpert · 2023-07-31T10:52:47Z

codecov · 2023-07-31T11:52:27Z

Codecov Report

Merging #6820 (bda3e0b) into main (39ccb5b) will increase coverage by 0.00%.
The diff coverage is 99.30%.

@@           Coverage Diff            @@
##             main    #6820    +/-   ##
========================================
  Coverage   96.42%   96.43%            
========================================
  Files        1401     1408     +7     
  Lines      334973   335687   +714     
  Branches    11072    11081     +9     
========================================
+ Hits       322997   323704   +707     
- Misses       9193     9198     +5     
- Partials     2783     2785     +2

src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/MakeTypesInternal.cs

Youssef1313 · 2023-08-03T11:48:48Z

src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/MakeTypesInternal.cs

+                compilationStartContext.RegisterSyntaxNodeAction(AnalyzeTypeDeclaration, TypeKinds);
+                compilationStartContext.RegisterSyntaxNodeAction(AnalyzeEnumDeclaration, EnumKind);


delegate declaration as well?

...NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/MakeTypesInternal.Fixer.cs

CollinAlpert · 2023-08-06T12:58:47Z

@Youssef1313 I have addressed your feedback.

mavasani · 2023-08-29T04:05:07Z

LGTM from a quick glance.

One suggestion: Analyzers that operate/bail out based on project output kind should probably be configurable to allow end users to override the applicable output kinds, we added such an option for CA2007: https://github.com/dotnet/roslyn-analyzers/blob/main/docs/Analyzer%20Configuration.md#analyzed-output-kinds

buyaa-n

Thank you @CollinAlpert, left a few comments, overall looks good.

...zers/CSharp/Microsoft.CodeQuality.Analyzers/Maintainability/CSharpMakeTypesInternal.Fixer.cs

...etAnalyzers/Core/Microsoft.CodeQuality.Analyzers/MicrosoftCodeQualityAnalyzersResources.resx

...nalyzers/UnitTests/Microsoft.CodeQuality.Analyzers/Maintainability/MakeTypesInternalTests.cs

# Conflicts: # src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md # src/NetAnalyzers/Microsoft.CodeAnalysis.NetAnalyzers.md # src/NetAnalyzers/RulesMissingDocumentation.md

CollinAlpert · 2023-09-24T20:06:52Z

@mavasani @buyaa-n Thank you for your feedback, I have addressed it.

src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/MakeTypesInternal.cs

buyaa-n · 2023-09-25T17:11:40Z

src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/MakeTypesInternal.cs

+                SyntaxTree? firstSyntaxTree;
+                if (compilation.Options.OutputKind is not (OutputKind.ConsoleApplication or OutputKind.WindowsApplication or OutputKind.WindowsRuntimeApplication)
+                    || (firstSyntaxTree = context.Compilation.SyntaxTrees.FirstOrDefault()) is null
+                    || !context.Options.GetOutputKindsOption(Rule, firstSyntaxTree, compilation).Contains(compilation.Options.OutputKind))


Thanks for making OutputKind configurable, though looks with the current logic only OutputKind.ConsoleApplication, OutputKind.WindowsApplication or OutputKind.WindowsRuntimeApplication are configurable, there is no way to enable the rule for OutputKind.DynamicallyLinkedLibrary. I think if it is giving an option to configure, all should be configurable, what you think @CollinAlpert @stephentoub?

Also please add the rule into Configurable Rules list in https://github.com/dotnet/roslyn-analyzers/blob/main/docs/Analyzer%20Configuration.md#analyzed-output-kinds

I agree, it is better to make all OutputKinds configurable.

...etAnalyzers/Core/Microsoft.CodeQuality.Analyzers/MicrosoftCodeQualityAnalyzersResources.resx

gewarren

I left a couple suggestions for the resource file.

...etAnalyzers/Core/Microsoft.CodeQuality.Analyzers/MicrosoftCodeQualityAnalyzersResources.resx

buyaa-n · 2023-09-25T20:38:13Z

I left a couple suggestions for the resource file.

Great, thank you @gewarren!

buyaa-n

Looks great to me, thank you @CollinAlpert!

Add MakeTypesInternalAnalyzer

3c09ae3

CollinAlpert requested a review from a team as a code owner July 31, 2023 10:52

github-actions bot added the Community label Jul 31, 2023

CollinAlpert added 4 commits July 31, 2023 13:16

Add FixAll support

8607e16

Add header comment.

ef03d12

Merge branch 'master' into issue_78388

7244561

Add file header

e2ecef9

Youssef1313 reviewed Aug 3, 2023

View reviewed changes

src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/MakeTypesInternal.cs Outdated Show resolved Hide resolved

Youssef1313 reviewed Aug 3, 2023

View reviewed changes

...NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/MakeTypesInternal.Fixer.cs Outdated Show resolved Hide resolved

CollinAlpert added 2 commits August 5, 2023 19:27

Merge branch 'master' into issue_78388

59c2ace

Address PR feedback

fa70d87

mavasani assigned buyaa-n Aug 29, 2023

buyaa-n reviewed Sep 23, 2023

View reviewed changes

CollinAlpert added 2 commits September 24, 2023 20:11

Merge branch 'master' into issue_78388

bc210a0

# Conflicts: # src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md # src/NetAnalyzers/Microsoft.CodeAnalysis.NetAnalyzers.md # src/NetAnalyzers/RulesMissingDocumentation.md

Applied code review suggestions.

075c130

buyaa-n reviewed Sep 25, 2023

View reviewed changes

src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/MakeTypesInternal.cs Outdated Show resolved Hide resolved

buyaa-n reviewed Sep 25, 2023

View reviewed changes

...etAnalyzers/Core/Microsoft.CodeQuality.Analyzers/MicrosoftCodeQualityAnalyzersResources.resx Outdated Show resolved Hide resolved

buyaa-n reviewed Sep 25, 2023

View reviewed changes

...etAnalyzers/Core/Microsoft.CodeQuality.Analyzers/MicrosoftCodeQualityAnalyzersResources.resx Outdated Show resolved Hide resolved

gewarren reviewed Sep 25, 2023

View reviewed changes

...etAnalyzers/Core/Microsoft.CodeQuality.Analyzers/MicrosoftCodeQualityAnalyzersResources.resx Outdated Show resolved Hide resolved

...etAnalyzers/Core/Microsoft.CodeQuality.Analyzers/MicrosoftCodeQualityAnalyzersResources.resx Outdated Show resolved Hide resolved

Make all OutputKinds configurable.

bda3e0b

buyaa-n approved these changes Sep 25, 2023

View reviewed changes

buyaa-n enabled auto-merge (squash) September 25, 2023 20:45

buyaa-n merged commit b39866e into dotnet:main Sep 25, 2023

CollinAlpert deleted the issue_78388 branch September 26, 2023 15:45

dependabot bot mentioned this pull request Aug 12, 2025

Bump Microsoft.CodeAnalysis.NetAnalyzers from 8.0.0-preview.23472.1 to 9.0.0 MyIntelligenceAgency/semantic-fleet#55

Open

This was referenced Sep 14, 2025

Bump Microsoft.CodeAnalysis.NetAnalyzers from 8.0.0 to 9.0.0 mrploch/ploch-templates-dotnet-with-common#4

Merged

deps: Bump the microsoft-packages group with 5 updates MachDatum/ThingConnect.Pulse#130

Closed

This was referenced Oct 28, 2025

deps: Bump the microsoft-packages group with 5 updates MachDatum/ThingConnect.Pulse#179

Closed

chore: Bump Microsoft.CodeAnalysis.NetAnalyzers from 8.0.0 to 9.0.0 gurame/Flowrex#10

Closed

		compilationStartContext.RegisterSyntaxNodeAction(AnalyzeTypeDeclaration, TypeKinds);
		compilationStartContext.RegisterSyntaxNodeAction(AnalyzeEnumDeclaration, EnumKind);

Conversation

CollinAlpert commented Jul 31, 2023

Uh oh!

codecov bot commented Jul 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Youssef1313 Aug 3, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CollinAlpert commented Aug 6, 2023

Uh oh!

mavasani commented Aug 29, 2023

Uh oh!

buyaa-n left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CollinAlpert commented Sep 24, 2023

Uh oh!

Uh oh!

buyaa-n Sep 25, 2023

Choose a reason for hiding this comment

Uh oh!

CollinAlpert Sep 25, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gewarren left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

buyaa-n commented Sep 25, 2023

Uh oh!

buyaa-n left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Jul 31, 2023 •

edited

Loading