Skip to content

Fix false-flag of CompareExchange and re-usage with loops#6979

Merged
jozkee merged 4 commits into
dotnet:mainfrom
jozkee:ca1869_bug
Oct 13, 2023
Merged

Fix false-flag of CompareExchange and re-usage with loops#6979
jozkee merged 4 commits into
dotnet:mainfrom
jozkee:ca1869_bug

Conversation

@jozkee

@jozkee jozkee commented Oct 13, 2023

Copy link
Copy Markdown
Member

Fixes #6957

@jozkee jozkee requested a review from a team as a code owner October 13, 2023 02:55
@codecov

codecov Bot commented Oct 13, 2023

Copy link
Copy Markdown

Codecov Report

Merging #6979 (dd6ead1) into main (8b1675a) will increase coverage by 0.00%.
Report is 3 commits behind head on main.
The diff coverage is 97.98%.

@@           Coverage Diff            @@
##             main    #6979    +/-   ##
========================================
  Coverage   96.42%   96.43%            
========================================
  Files        1410     1410            
  Lines      335956   336154   +198     
  Branches    11095    11103     +8     
========================================
+ Hits       323956   324161   +205     
+ Misses       9207     9198     -9     
- Partials     2793     2795     +2     

@eiriktsarpalis eiriktsarpalis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jozkee!

@buyaa-n buyaa-n left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jozkee jozkee merged commit ac6c703 into dotnet:main Oct 13, 2023
@jozkee jozkee deleted the ca1869_bug branch October 13, 2023 19:06
@eiriktsarpalis

Copy link
Copy Markdown
Member

@buyaa-n is there any action required to get this fix bundled with .NET 8?

@buyaa-n

buyaa-n commented Oct 13, 2023

Copy link
Copy Markdown

I think it's same as runtime porting, let managers know and agreed with porting, create a backport with /backport to release/8.0, fill in the description, I believe then need to send out emails to tactics for approval. CC @carlossanlop

@jozkee

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

@jozkee

jozkee commented Oct 16, 2023

Copy link
Copy Markdown
Member Author

/backport to release/8.0.1xx

@github-actions

Copy link
Copy Markdown

Started backporting to release/8.0.1xx: https://github.com/dotnet/roslyn-analyzers/actions/runs/6536547982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CA1869 is flagging lazily-initialized JsonSerializerOptions construction

3 participants