Skip to content

CA2237: Don't report diagnostic when ISerializable is inherited#6997

Merged
buyaa-n merged 1 commit into
dotnet:mainfrom
david-acker:bug/CA2237-ISerializable-directly
Nov 18, 2023
Merged

CA2237: Don't report diagnostic when ISerializable is inherited#6997
buyaa-n merged 1 commit into
dotnet:mainfrom
david-acker:bug/CA2237-ISerializable-directly

Conversation

@david-acker

Copy link
Copy Markdown
Member

Fixes #6916

@david-acker david-acker requested a review from a team as a code owner October 21, 2023 03:30
@codecov

codecov Bot commented Oct 21, 2023

Copy link
Copy Markdown

Codecov Report

Merging #6997 (2d3c1f0) into main (80ac926) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #6997   +/-   ##
=======================================
  Coverage   96.43%   96.43%           
=======================================
  Files        1410     1410           
  Lines      336238   336270   +32     
  Branches    11106    11106           
=======================================
+ Hits       324235   324275   +40     
+ Misses       8899     8893    -6     
+ Partials     3104     3102    -2     

@buyaa-n buyaa-n left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @david-acker

@buyaa-n buyaa-n merged commit cc67474 into dotnet:main Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CA2237 should only fire if a type have implemented the ISerializable interface directly

2 participants