Make it easier to run the tool locally#565
Conversation
| || environmentStatus.Equals(EnvironmentStatus.Queued) | ||
| || environmentStatus.Equals(EnvironmentStatus.NotStarted) | ||
| || environmentStatus.Equals(EnvironmentStatus.Scheduled))) | ||
| if (environmentStatus != EnvironmentStatus.InProgress |
There was a problem hiding this comment.
this change keeps the tool from spinning for 10 minutes waiting for a release that isn't actually happening.
There was a problem hiding this comment.
Do we need any of this release stuff at all? What is the release for?
There was a problem hiding this comment.
The comments make it seem like it is supposed to do symbol publishing for the build we're inserting. But it's not clear to me if that is still something that RIT users need to be worried about, or whether it's something that just happens as part of the signed build pipeline. Can you shed any light @brettfo?
| } | ||
|
|
||
| Console.WriteLine("---PR description---"); | ||
| Console.WriteLine(prDescription); |
There was a problem hiding this comment.
Eventually I'd like to have a dry-run flag for local testing so we can have decent experience finally getting to the bottom of #502
dibarbet
left a comment
dibarbet
left a comment
There was a problem hiding this comment.
Approving so we can at least avoid the 10min delay. Should definitely followup on if we can remove the release all together though.
|
closing in lieu of #570 |
2 participants
This PR adds a
/localflag to run the tool locally. It prompts you with a nice popup login window. This way you don't have to type your corporate username and password in the command line/save it in VS debug options/other bad stuff like that.TODO: make pushing the PR branch locally work. I suspect the client credential uses a token but libgit2sharp doesn't expose any way to provide a custom header with the token for a git push. So we would have to either:
Process.Start("git", ...).WaitForExit()/cc @JoeRobich @dibarbet @jmarolf