Merged
Conversation
Collaborator
|
I took a look at it and I turned out that the problem is with the refactoring which has the same functionality as the analyzer: |
Collaborator
|
@jakubreznak Could you fix it? |
Contributor
Author
|
Yeah, sorry, i will look at it, but I am not able to do it this week. |
Contributor
Author
|
I looked at it and fixed it, also added a test. Thank you for your suggestion. |
josefpihrt
requested changes
Nov 17, 2023
src/Common/CSharp/Analysis/CallExtensionMethodAsInstanceMethodAnalysis.cs
Show resolved
Hide resolved
src/Common/CSharp/Analysis/CallExtensionMethodAsInstanceMethodAnalysis.cs
Show resolved
Hide resolved
josefpihrt
reviewed
Nov 18, 2023
josefpihrt
approved these changes
Nov 20, 2023
Collaborator
|
@jakubreznak Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added test for RCS1196
resolve #1128
I tested it and there were no redundant parentheses. I also wrote test for it.