RCS1268 - Simplify Numeric Comparison#1405
Merged
josefpihrt merged 7 commits intodotnet:mainfrom Feb 26, 2024
Merged
Conversation
Collaborator
|
Is this PR ready for review? If so, can you request a review? |
Contributor
Author
|
Yes, the PR is ready for review. Could you please review my code? Thanks (I wanted to add you to reviewers, but i cannot.) |
Collaborator
|
I see, I didn't know you cannot request a review. So, just to be clear, what do you see in the UI? I see this:
|
Contributor
Author
|
I see this. |
Collaborator
|
Thanks for the screenshot. It's probably because the repo is part of dotnet organization. |
josefpihrt
requested changes
Feb 23, 2024
src/Analyzers/CSharp/Analysis/SimplifyNumericComparisonAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Analyzers.CodeFixes/CSharp/CodeFixes/BinaryExpressionCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thank you for the code review and your suggestions. I have implemented the changes you suggested. |
josefpihrt
approved these changes
Feb 25, 2024
Collaborator
|
@jakubreznak Nice PR, thanks! |
Contributor
Collaborator
|
@BenjaminBrienen Changelog contains incorrect information that this analyzer is part of 4.11.0 but it haven't been released yet. Changelog will be fixed as a part of next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1394