System.Xml.Tests.CNameTableTestModule.RunTests failure on Windows Server 2022

[runfoapp]

System.Xml.Tests.CNameTableTestModule.RunTests(testCase: Get Valid Super String) [FAIL]
    OLEDB.Test.ModuleCore.CTestException : objTest2 is null
    Expected: `True`
    Actual: `False`
    Result: 0
    
    Stack Trace:
    /_/src/libraries/System.Private.Xml/tests/Readers/NameTable/XmlNameTable.cs(346,0): at System.Xml.Tests.TCRecordNameTableGet.Variation_10()
    /_/src/libraries/Common/tests/System/Xml/ModuleCore/cvariation.cs(80,0): at OLEDB.Test.ModuleCore.CVariation.Execute()
    /_/src/libraries/Common/tests/System/Xml/ModuleCore/ctestcase.cs(131,0): at OLEDB.Test.ModuleCore.CTestCase.<>c__DisplayClass7_1.<TestCases>b__0()
    /_/src/libraries/Common/tests/System/Xml/ModuleCore/XunitTestCase.cs(37,0): at OLEDB.Test.ModuleCore.XunitTestCase.Run()
    /_/src/libraries/System.Private.Xml/tests/Readers/NameTable/CNameTableTestModule.cs(16,0): at System.Xml.Tests.CNameTableTestModule.RunTests(XunitTestCase testCase)

runtime/src/libraries/System.Private.Xml/tests/Readers/NameTable/XmlNameTable.cs

Lines 332 to 347 in 57bfe47

	XmlReader rDataReader = XmlReader.Create(FilePathUtil.getStream(filename));
	while (rDataReader.Read() == true) ;
	XmlNameTable nt = rDataReader.NameTable;
	object objTest1 = nt.Get(BigStr + "Z");
	object objTest2 = nt.Get(BigStr + "X");
	object objTest3 = nt.Get(BigStr + "Y");
	if (objTest1 != null)
	{
	throw new CTestException(CTestBase.TEST_FAIL, "objTest1 is not null");
	}
	if (objTest2 == null)
	{
	throw new CTestException(CTestBase.TEST_FAIL, "objTest2 is null");
	}

Runfo Tracking Issue: system.xml.tests.cnametabletestmodule.runtests

Build	Definition	Kind	Run Name	Console	Core Dump	Test Results	Run Client
1612202	runtime-extra-platforms	Rolling	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1612202	runtime-extra-platforms	Rolling	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1611370	runtime-extra-platforms	PR 64452	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1611370	runtime-extra-platforms	PR 64452	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1610942	runtime-extra-platforms	Rolling	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1610942	runtime-extra-platforms	Rolling	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1609873	runtime-extra-platforms	Rolling	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1609873	runtime-extra-platforms	Rolling	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1608296	runtime-extra-platforms	Rolling	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1608296	runtime-extra-platforms	Rolling	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1606693	runtime-extra-platforms	Rolling	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1606693	runtime-extra-platforms	Rolling	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1605694	runtime-extra-platforms	PR 60905	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1605694	runtime-extra-platforms	PR 60905	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1603058	runtime-extra-platforms	PR 64452	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1603058	runtime-extra-platforms	PR 64452	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1602227	runtime-extra-platforms	PR 64452	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1602227	runtime-extra-platforms	PR 64452	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py

Build Result Summary

Day Hit Count	Week Hit Count	Month Hit Count
3	9	9

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Runfo Creating Tracking Issue (data being generated)

Author:	runfoapp[bot]
Assignees:	-
Labels:	area-Diagnostics-coreclr, untriaged
Milestone:	-

Tagging subscribers to this area: @dotnet/area-system-xml
See info in area-owners.md if you want to be subscribed.

Issue Details

---

System.Xml.Tests.CNameTableTestModule.RunTests(testCase: Get Valid Super String) [FAIL]
    OLEDB.Test.ModuleCore.CTestException : objTest2 is null
    Expected: `True`
    Actual: `False`
    Result: 0
    
    Stack Trace:
    /_/src/libraries/System.Private.Xml/tests/Readers/NameTable/XmlNameTable.cs(346,0): at System.Xml.Tests.TCRecordNameTableGet.Variation_10()
    /_/src/libraries/Common/tests/System/Xml/ModuleCore/cvariation.cs(80,0): at OLEDB.Test.ModuleCore.CVariation.Execute()
    /_/src/libraries/Common/tests/System/Xml/ModuleCore/ctestcase.cs(131,0): at OLEDB.Test.ModuleCore.CTestCase.<>c__DisplayClass7_1.<TestCases>b__0()
    /_/src/libraries/Common/tests/System/Xml/ModuleCore/XunitTestCase.cs(37,0): at OLEDB.Test.ModuleCore.XunitTestCase.Run()
    /_/src/libraries/System.Private.Xml/tests/Readers/NameTable/CNameTableTestModule.cs(16,0): at System.Xml.Tests.CNameTableTestModule.RunTests(XunitTestCase testCase)

runtime/src/libraries/System.Private.Xml/tests/Readers/NameTable/XmlNameTable.cs

Lines 332 to 347 in 57bfe47

	XmlReader rDataReader = XmlReader.Create(FilePathUtil.getStream(filename));
	while (rDataReader.Read() == true) ;
	XmlNameTable nt = rDataReader.NameTable;
	object objTest1 = nt.Get(BigStr + "Z");
	object objTest2 = nt.Get(BigStr + "X");
	object objTest3 = nt.Get(BigStr + "Y");
	if (objTest1 != null)
	{
	throw new CTestException(CTestBase.TEST_FAIL, "objTest1 is not null");
	}
	if (objTest2 == null)
	{
	throw new CTestException(CTestBase.TEST_FAIL, "objTest2 is null");
	}

Runfo Tracking Issue: system.xml.tests.cnametabletestmodule.runtests

Build	Definition	Kind	Run Name	Console	Core Dump	Test Results	Run Client
1608296	runtime-extra-platforms	Rolling	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1608296	runtime-extra-platforms	Rolling	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1606693	runtime-extra-platforms	Rolling	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1606693	runtime-extra-platforms	Rolling	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1605694	runtime-extra-platforms	PR 60905	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1605694	runtime-extra-platforms	PR 60905	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1603058	runtime-extra-platforms	PR 64452	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1603058	runtime-extra-platforms	PR 64452	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1602227	runtime-extra-platforms	PR 64452	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py
1602227	runtime-extra-platforms	PR 64452	net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open	console.log			runclient.py

Build Result Summary

Day Hit Count	Week Hit Count	Month Hit Count
2	5	5

Author:	runfoapp[bot]
Assignees:	-
Labels:	area-System.Xml, untriaged
Milestone:	-

[danmoseley]

One of these is not like the others

  Starting:    System.Xml.RW.NameTable.Tests (parallel test collections = on, max threads = 2)
    System.Xml.Tests.CNameTableTestModule.RunTests(testCase: Add an existing atomized string (with Max string for test: 1-2M), valid offset and valid length) [FAIL]
      System.Xml.XmlException : The '.' character, hexadecimal value 0x00, cannot be included in a name. Line 2, position 860041.
      Stack Trace:
        /_/src/libraries/System.Private.Xml/src/System/Xml/Core/XmlTextReaderImpl.cs(2813,0): at System.Xml.XmlTextReaderImpl.Throw(Exception e)
        /_/src/libraries/System.Private.Xml/src/System/Xml/Core/XmlTextReaderImpl.cs(2787,0): at System.Xml.XmlTextReaderImpl.Throw(String res, String[] args)
        /_/src/libraries/System.Private.Xml/src/System/Xml/Core/XmlTextReaderImpl.cs(4544,0): at System.Xml.XmlTextReaderImpl.ParseElement()
        /_/src/libraries/System.Private.Xml/src/System/Xml/Core/XmlTextReaderImpl.cs(4312,0): at System.Xml.XmlTextReaderImpl.ParseElementContent()
        /_/src/libraries/System.Private.Xml/src/System/Xml/Core/XmlTextReaderImpl.cs(1236,0): at System.Xml.XmlTextReaderImpl.Read()
        /_/src/libraries/System.Private.Xml/tests/Readers/NameTable/XmlNameTable.cs(778,0): at System.Xml.Tests.TCRecordNameTableAdd.Variation_8()
        /_/src/libraries/Common/tests/System/Xml/ModuleCore/cvariation.cs(80,0): at OLEDB.Test.ModuleCore.CVariation.Execute()
        /_/src/libraries/Common/tests/System/Xml/ModuleCore/ctestcase.cs(131,0): at OLEDB.Test.ModuleCore.CTestCase.<>c__DisplayClass7_1.<TestCases>b__0()
        /_/src/libraries/Common/tests/System/Xml/ModuleCore/XunitTestCase.cs(37,0): at OLEDB.Test.ModuleCore.XunitTestCase.Run()
        /_/src/libraries/System.Private.Xml/tests/Readers/NameTable/CNameTableTestModule.cs(16,0): at System.Xml.Tests.CNameTableTestModule.RunTests(XunitTestCase testCase)
  Finished:    System.Xml.RW.NameTable.Tests

but it seems the same root cause -- in both cases, the element name being read is not exactly equal to new string('Z', (1 << 20) - 1); as it's expected to be.

It's not just server 2022, also Windows 7 at least.

[danmoseley]

could this be related to #63459? Having trouble querying to find out when it started.

[danmoseley]

Looped this test library 600 times on Windows 10 x64, no failures, now I'll try 32 bit

[danmoseley]

I ran the whole library 9500 times on x86, no failures.

[danmoseley]

This seems like a relevant bug. It wraps a MemoryStream with a StreamWriter, flushes the StreamWriter, then leaves it dangling and returns the MemoryStream

runtime/src/libraries/System.Private.Xml/tests/Readers/NameTable/TestFiles.cs

Lines 278 to 294 in 0238a39

	MemoryStream ms = new MemoryStream();
	TextWriter tw = new StreamWriter(ms);
	string str = new string('Z', (1 << 20) - 1);
	tw.WriteLine("<Root>");
	tw.Write("<");
	tw.Write(str);
	tw.WriteLine("X />");
	tw.Flush();
	tw.Write("<");
	tw.Write(str);
	tw.WriteLine("Y />");
	tw.WriteLine("</Root>");
	tw.Flush();
	FilePathUtil.addStream(strFileName, ms);

That would cause a random ODE when the StreamWriter is finalized, not the error we're seeing here.

There may also be some issues with a memory stream getting used concurrently. It copies MemoryStream's to fresh ones -- if this is happening concurrently with use, that could cause a torn copy leaving nulls in it causing this symptom. Let me see whether I can clean this up.