[release/8.0-staging] Revert "disable optimizations for PopCount (#99796)"#101245
Merged
carlossanlop merged 1 commit intorelease/8.0-stagingfrom May 2, 2024
Merged
Conversation
This reverts commit aee4957.
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jeffschwMSFT
approved these changes
Apr 25, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. we will take for consideration in 8.0.x
Contributor
|
@mangod9 @JulieLeeMSFT @jeffschwMSFT if this is ready for Tactics, can someone please send the email requesting approval and add the |
carlossanlop
added
Servicing-approved
Contributor
|
Approved by Tactics via email. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #100926 to release/8.0-staging
/cc @mangod9
Customer Impact
This is a change to revert a workaround for a compiler bug which was incorrectly generating popcnt SSE4 instructions.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Tested manually on a non-SSE4 machine.
Risk
[Low.] since it's simply a revert of a previous workaround to disable optimizations for a few methods.