Fix mono regressions in Number.Formatting.cs#112050
Closed
EgorBo wants to merge 6 commits intodotnet:mainfrom
Closed
Fix mono regressions in Number.Formatting.cs#112050EgorBo wants to merge 6 commits intodotnet:mainfrom
EgorBo wants to merge 6 commits intodotnet:mainfrom
Conversation
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
Member
Author
|
@EgorBot -amd -arm -mono --filter System.Text.Json.Tests.Perf_DateTimes* |
Member
Author
|
@EgorBot -amd -arm -mono --filter System.Text.Json.Tests.Perf_DateTimes* |
This was referenced Feb 1, 2025
Closed
This was referenced Feb 2, 2025
This was referenced Feb 10, 2025
This was referenced Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a PR that refactors Number.Formatting.cs to make it safer, but in between, let's see if this minimal fix fixes the