Skip to content

Fix path to dotnet.sh in AndroidSampleApp project #112590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elinor-fung merged 2 commits into from
Feb 19, 2025
Merged

Fix path to dotnet.sh in AndroidSampleApp project #112590

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77a3aa9
Fix path to dotnet.sh in AndroidSampleApp
elinor-fung Feb 14, 2025
926ba3d
Use DotNetTool property
elinor-fung Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/mono/sample/Android/AndroidSampleApp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
<!-- With Mono AOT on Android we default to not using AOT data file optimization as it can degrade runtime performance for small binary size improvements. -->
<_UseAotDataFile Condition="'$(RunAOTCompilation)' == 'true'">false</_UseAotDataFile>
<RepoDotnet Condition="'$(DOTNET_ROOT)' != ''">$(DOTNET_ROOT)/dotnet</RepoDotnet>
<RepoDotnet Condition="'$(RepoDotnet)' == '' and '$(OS)' == 'Windows_NT'">..\..\..\..\dotnet.cmd</RepoDotnet>
<RepoDotnet Condition="'$(RepoDotnet)' == '' and '$(OS)' != 'Windows_NT'">../../../dotnet.sh</RepoDotnet>
<RepoDotnet Condition="'$(RepoDotnet)' == '' and '$(OS)' == 'Windows_NT'">$(RepoRoot)dotnet.cmd</RepoDotnet>
<RepoDotnet Condition="'$(RepoDotnet)' == '' and '$(OS)' != 'Windows_NT'">$(RepoRoot)dotnet.sh</RepoDotnet>
Copy link
Copy Markdown
Member

@ivanpovazan ivanpovazan Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need RepoDotnet property at all. We can instead just use $(DotNetTool) at line 34: https://github.com/dotnet/runtime/pull/112590/files#diff-1e632e29d3bd8c79a2aa62b91516646c9bc2bf0d2fa55089c3d4f25669e85eb0R34
and remove RepoDotnet.

DotNetTool gets properly resolved in: https://github.com/dotnet/arcade/blob/ae3c938af5df4a2db45ded37dd05608ce59d8e5e/src/Microsoft.DotNet.Arcade.Sdk/tools/RepoLayout.props#L20-L31
for Windows and non-Windows hosts.

</PropertyGroup>

<ItemGroup>
Expand Down