Haiku: Add minipal_getexepath implementation#114519
Conversation
ghost
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
| return NULL; | ||
| } | ||
|
|
||
| return realpath(path, NULL); |
There was a problem hiding this comment.
This return statement appears before the HAIKU branch, causing the Haiku-specific code to be bypassed. Consider moving this statement inside the appropriate conditional branch so that the Haiku implementations execute correctly.
jkotas
added
area-PAL-coreclr
and removed
needs-area-label
trungnt2910
force-pushed
the
dev/trungnt2910/haiku-minipal
branch
2 times, most recently
from
3fd4df7 to
fcf2e8c
Compare
trungnt2910
force-pushed
the
dev/trungnt2910/haiku-minipal
branch
from
fcf2e8c to
9b754cc
Compare
|
You do not need to force push unless you want to make changes in the PR. A lot of the CI failures are known issues. The maintainers will look at CI failures and re-trigger the CI as necessary. |
And if you need to make changes in the PR, it is best to make them as additional commit instead of force pushing. Check out contribution guidelines at https://github.com/dotnet/runtime/blob/main/docs/workflow/ci/pr-guide.md#quick-code-review-rules |
Add an implementation to get the full path to the current process's main executable based on the Haiku API.
Part of #55803.