Optimise char to hex conversion #116821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

xtqqczze wants to merge 4 commits into dotnet:main from xtqqczze:sbyte-CharToHexLookup

Closed

Optimise char to hex conversion #116821

Reintroduce `FromChar` bounds check

Azure Pipelines / runtime (Build Libraries Test Run checked coreclr windows x86 Debug) failed Jul 10, 2025 in 34m 34s

Build Libraries Test Run checked coreclr windows x86 Debug failed

12 errors / 0 warnings

Annotations

Check failure on line 44 in .packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25359.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets

azure-pipelines / runtime (Build Libraries Test Run checked coreclr windows x86 Debug)

.packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25359.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets#L44

.packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25359.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets(44,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Test System.Buffers.Text.Tests.Base64UrlDecoderUnitTests.EncodeAndDecodeInPlace has failed. Check the Test tab or this console log: https://helix.dot.net/api/2019-06-17/jobs/c97b30f2-0397-4ab2-a55a-a11f42eca2b8/workitems/System.Memory.Tests/console

Check failure on line 44 in .packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25359.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets

azure-pipelines / runtime (Build Libraries Test Run checked coreclr windows x86 Debug)

.packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25359.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets#L44

.packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25359.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets(44,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Test System.Buffers.Text.Tests.Base64UrlEncoderUnitTests.BasicEncodingWithFinalBlockFalse has failed. Check the Test tab or this console log: https://helix.dot.net/api/2019-06-17/jobs/c97b30f2-0397-4ab2-a55a-a11f42eca2b8/workitems/System.Memory.Tests/console

Check failure on line 44 in .packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25359.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets

azure-pipelines / runtime (Build Libraries Test Run checked coreclr windows x86 Debug)

.packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25359.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets#L44

.packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25359.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets(44,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Test System.Buffers.Text.Tests.Base64UrlEncoderUnitTests.BasicEncodingAndDecoding has failed. Check the Test tab or this console log: https://helix.dot.net/api/2019-06-17/jobs/c97b30f2-0397-4ab2-a55a-a11f42eca2b8/workitems/System.Memory.Tests/console

Check failure on line 44 in .packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25359.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets

azure-pipelines / runtime (Build Libraries Test Run checked coreclr windows x86 Debug)

.packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25359.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets#L44

.packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25359.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets(44,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Test System.Buffers.Text.Tests.Base64UrlUnicodeAPIsUnitTests.Base64_AllMethodsRoundtripConsistently has failed. Check the Test tab or this console log: https://helix.dot.net/api/2019-06-17/jobs/c97b30f2-0397-4ab2-a55a-a11f42eca2b8/workitems/System.Memory.Tests/console

Check failure on line 44 in .packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25359.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets

azure-pipelines / runtime (Build Libraries Test Run checked coreclr windows x86 Debug)

.packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25359.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets#L44

.packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25359.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets(44,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Test System.Buffers.Text.Tests.Base64UrlUnicodeAPIsUnitTests.RoundTripWithLargeSpan has failed. Check the Test tab or this console log: https://helix.dot.net/api/2019-06-17/jobs/c97b30f2-0397-4ab2-a55a-a11f42eca2b8/workitems/System.Memory.Tests/console

View more details on Azure Pipelines