JIT: Avoid creating impossible equality assertions#118586
Merged
jakobbotsch merged 1 commit intodotnet:mainfrom Aug 11, 2025
Merged
JIT: Avoid creating impossible equality assertions#118586jakobbotsch merged 1 commit intodotnet:mainfrom
jakobbotsch merged 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #113940 by preventing the creation of impossible equality assertions in the JIT compiler's assertion propagation optimization. The fix addresses cases where a small local variable (like byte or short) would be compared to a constant value outside its valid range, which would create impossible assertions that could cause problems elsewhere in the compiler.
- Adds validation to detect when a truncated constant value differs from the original value for small local variables
- Avoids creating assertions for impossible equality comparisons that indicate unreachable code
- Maintains existing behavior for store operations while fixing the issue for other operations
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
Author
|
cc @dotnet/jit-contrib PTAL @EgorBo |
Member
Author
This was referenced Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #113940