Skip to content

Limit native AOT to CORINFO_HELP_ALLOC_CONTINUATION#121444

Merged
MichalStrehovsky merged 2 commits into
dotnet:mainfrom
MichalStrehovsky:aotalloccontinuation
Nov 10, 2025
Merged

Limit native AOT to CORINFO_HELP_ALLOC_CONTINUATION#121444
MichalStrehovsky merged 2 commits into
dotnet:mainfrom
MichalStrehovsky:aotalloccontinuation

Conversation

@MichalStrehovsky

Copy link
Copy Markdown
Member

Native AOT doesn't have a MethodDesc at runtime. But that's fine, we don't have a loader to keep alive either.

Cc @dotnet/ilc-contrib

@MichalStrehovsky MichalStrehovsky added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 7, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restricts the use of specialized continuation allocation helpers to non-Native AOT scenarios. Native AOT doesn't require the loader keep-alive mechanism since it lacks a runtime MethodDesc and doesn't have a loader to maintain. The change adds IsTargetAbi(CORINFO_NATIVEAOT_ABI) checks to ensure Native AOT always uses CORINFO_HELP_ALLOC_CONTINUATION instead of the keep-alive variants.

  • Added Native AOT ABI checks to skip loader keep-alive logic
  • Forces Native AOT to use standard continuation allocation helper

Comment thread src/coreclr/jit/async.cpp Outdated
Comment thread src/coreclr/jit/async.cpp Outdated
Native AOT doesn't have a `MethodDesc` at runtime. But that's fine, we don't have a loader to keep alive either.
@MichalStrehovsky

Copy link
Copy Markdown
Member Author

/ba-g android timeout is dotnet/dnceng#6408

@MichalStrehovsky MichalStrehovsky merged commit e689bf8 into dotnet:main Nov 10, 2025
100 of 112 checks passed
@MichalStrehovsky MichalStrehovsky deleted the aotalloccontinuation branch November 10, 2025 11:48
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI runtime-async

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants