Skip to content

Fix ValueTask`1.ConfigureAwait intrinsic detection#121612

Merged
MichalStrehovsky merged 1 commit into
mainfrom
MichalStrehovsky-patch-1
Nov 14, 2025
Merged

Fix ValueTask`1.ConfigureAwait intrinsic detection#121612
MichalStrehovsky merged 1 commit into
mainfrom
MichalStrehovsky-patch-1

Conversation

@MichalStrehovsky

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a typo in the JIT compiler's intrinsic detection logic that prevented proper recognition of the ConfigureAwait method on ValueTask<T>. The typo "ValuTask1" has been corrected to "ValueTask1", ensuring the intrinsic optimization can be applied correctly.

Key Changes

  • Corrected spelling from "ValuTask1" to "ValueTask1" in the intrinsic lookup logic for ConfigureAwait

@jakobbotsch jakobbotsch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that should fix #121564 (comment)

@VSadov

VSadov commented Nov 14, 2025

Copy link
Copy Markdown
Member

I have seen this typo and I thought I have fixed it in #120704. But somehow the fix for the typo did not make it.

Most likely I tested the fix in the Libraries PR with bunch of other fixes, but when I cherrypicked the commits into a standalone PR with just patternmatch implementation for ValueTask.ConfigureAwait, I missed the typo fix for the generic intrinsic.

Thanks for fixing this!

@github-actions github-actions Bot locked and limited conversation to collaborators Dec 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI runtime-async

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants