[release/10.0] Update MicrosoftCodeAnalysisVersion_LatestVS #123509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To match what is referenced in the 10.0.1xx SDK: https://github.com/dotnet/sdk/blob/0b3258423a96e6b0e0582a31f09e10ce4478fc06/eng/Version.Details.xml#L95
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-reflection-metadata |
jkoritzinsky
approved these changes
Jan 22, 2026
eng/Versions.props
Outdated
| such that any version that satisfies the VS version requirement will also satisfy the .NET SDK version requirement because of how we ship. | ||
| --> | ||
| <MicrosoftCodeAnalysisVersion_LatestVS>4.14.0</MicrosoftCodeAnalysisVersion_LatestVS> | ||
| <MicrosoftCodeAnalysisVersion_LatestVS>5.0.0-2.26070.104</MicrosoftCodeAnalysisVersion_LatestVS> |
Member
There was a problem hiding this comment.
When porting this to main, can we introduce a new property like the ones above for the 10.0.1xx sdks?
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the Microsoft.CodeAnalysis (Roslyn) version to 5.0.0-2.26070.104 to match the version referenced in the 10.0.1xx SDK. The update introduces a new analyzer warning (IDE0071) that requires a pragma suppression in one location.
Changes:
- Updates
MicrosoftCodeAnalysisVersion_LatestVSfrom 4.14.0 to 5.0.0-2.26070.104 - Adds pragma warning suppression for IDE0071 around a Debug.Assert statement that uses ToString() on a ReadOnlySpan
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/Versions.props | Updates the Roslyn/CodeAnalysis version to 5.0.0-2.26070.104 to match the 10.0.1xx SDK |
| src/libraries/System.Reflection.Metadata/src/System/Reflection/Metadata/TypeNameParser.cs | Adds pragma warning disable/restore for IDE0071 around a Debug.Assert to suppress a new analyzer warning introduced in Roslyn 5.0 |
sbomer
commented
Jan 23, 2026
eng/Versions.props
Outdated
| such that any version that satisfies the VS version requirement will also satisfy the .NET SDK version requirement because of how we ship. | ||
| --> | ||
| <MicrosoftCodeAnalysisVersion_LatestVS>4.14.0</MicrosoftCodeAnalysisVersion_LatestVS> | ||
| <MicrosoftCodeAnalysisVersion_LatestVS>5.0.0-2.26070.104</MicrosoftCodeAnalysisVersion_LatestVS> |
Member
Author
There was a problem hiding this comment.
I see 10.0.100 SDK shipped with version 5.0.0-2.25523.111, maybe we should use that one instead @jkoritzinsky?
edit: seems that version isn't available in the nuget feeds. Could you help me pick the right version here?
Member
Author
There was a problem hiding this comment.
I updated this to use the version that ships with the 10.0.102 SDK as that was the earliest SDK-included version available in our nuget feeds (I tried 10.0.100 and 10.0.101 and those packages don't seem to exist, maybe they are removed from internal feeds once we ship?), and that version is lower than what's in the dotnet/sdk 10.0.1xxx branch so it seems slightly safer.
Member
There was a problem hiding this comment.
Another good option here would be to use 5.0.0 as the "Latest VS" version, as that is a publicly available version and definitely works in VS/.NET 10 SDK and has any expected API changes.
agocke
added a commit
that referenced
this pull request
Jan 24, 2026
) ## Description Updates Roslyn to 5.0.0-2.26070.104 to match the 10.0.1xx SDK. The new analyzer version enforces IDE0071 and IDE0031 more strictly, causing build failures with `TreatWarningsAsErrors=true`. ## Changes **eng/Versions.props** - Bump `MicrosoftCodeAnalysisVersion_LatestVS`: `4.14.0` → `5.0.0-2.26070.104` **.editorconfig** (global `[*.cs]` section) - Add `dotnet_diagnostic.IDE0071.severity = silent` - Suppresses false positives for `ReadOnlySpan<char>.ToString()` in string interpolations (required for netstandard targets where ReadOnlySpan cannot be directly interpolated) - Add `dotnet_diagnostic.IDE0031.severity = silent` - Suppresses null propagation suggestions Setting `silent` severity preserves IDE hints while preventing build errors. ## Testing Resolves build failures in: - `System.Security.Cryptography.MLDsaCng.Windows.cs` - `System.Security.Cryptography.MLDsaImplementation.Windows.cs` - `System.Reflection.Metadata.TypeNameParser.cs` <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > This is a port of PR #123509 from `release/10.0` to `main`. > > ## Summary > Update `MicrosoftCodeAnalysisVersion_LatestVS` to match what is referenced in the 10.0.1xx SDK: > https://github.com/dotnet/sdk/blob/0b3258423a96e6b0e0582a31f09e10ce4478fc06/eng/Version.Details.xml#L95 > > ## Changes Required > > ### 1. eng/Versions.props > Update the `MicrosoftCodeAnalysisVersion_LatestVS` property from `4.14.0` to `5.0.0-2.26070.104`: > > ```xml > - <MicrosoftCodeAnalysisVersion_LatestVS>4.14.0</MicrosoftCodeAnalysisVersion_LatestVS> > + <MicrosoftCodeAnalysisVersion_LatestVS>5.0.0-2.26070.104</MicrosoftCodeAnalysisVersion_LatestVS> > ``` > > ### 2. src/libraries/Common/src/System/Security/Cryptography/MLDsaCng.Windows.cs > Add `#pragma warning disable/restore IDE0071` around the `Debug.Fail` call to fix ReadOnlySpan interpolation for netstandard targets: > > ```csharp > +#pragma warning disable IDE0071 > Debug.Fail( > $"{nameof(blobType)}: {blobType}, " + > $"{nameof(parameterSet)}: {parameterSet.ToString()}, " + > $"{nameof(keyBytes)}.Length: {keyBytes.Length} / {expectedKeySize}"); > +#pragma warning restore IDE0071 > ``` > > ### 3. src/libraries/Common/src/System/Security/Cryptography/MLDsaImplementation.Windows.cs > Same change - add `#pragma warning disable/restore IDE0071` around the `Debug.Fail` call: > > ```csharp > +#pragma warning disable IDE0071 > Debug.Fail( > $"{nameof(blobType)}: {blobType}, " + > $"{nameof(parameterSet)}: {parameterSet.ToString()}, " + > $"{nameof(keyBytes)}.Length: {keyBytes.Length} / {expectedKeySize}"); > +#pragma warning restore IDE0071 > ``` > > ### 4. src/libraries/System.Reflection.Metadata/src/System/Reflection/Metadata/TypeNameParser.cs > Add `#pragma warning disable/restore IDE0071` around the `Debug.Assert` call: > > ```csharp > +#pragma warning disable IDE0071 > Debug.Assert(parsedName.GetNodeCount() == recursiveDepth, $"Node count mismatch for '{typeName.ToString()}'"); > +#pragma warning restore IDE0071 > ``` > > ## Context > The newer version of Microsoft.CodeAnalysis (5.0.0-2.26070.104) introduces a new analyzer warning IDE0071 (redundant ToString() in string interpolation) that triggers on `ReadOnlySpan<char>.ToString()` calls in interpolated strings. However, for netstandard targets, these `.ToString()` calls are required because `ReadOnlySpan<char>` cannot be directly interpolated. The pragma warnings suppress this false positive while keeping the necessary `.ToString()` calls. > > Related issue: #123503 </details> <!-- START COPILOT CODING AGENT SUFFIX --> *This pull request was created from Copilot chat.* > <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: agocke <[email protected]>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match what is referenced in the 10.0.1xx SDK:
https://github.com/dotnet/sdk/blob/0b3258423a96e6b0e0582a31f09e10ce4478fc06/eng/Version.Details.xml#L95
Fixes #123503
Customer Impact
When using a .NET 11 SDK to build a net10.0 project with trimming enabled, the trim analyzer crashes on extension properties:
Regression
This regressed with the removal of a preview Roslyn API in .NET 11: dotnet/dotnet#2822.
These APIs were marked
[Obsolete]in .NET 10 but this did not cause build failures because:[Obsolete].Testing
The fix was verified on a repro app referencing a local build of the analyzer with the updated Microsoft.CodeAnalysis version. Existing test coverage in this repo also validates the behavior when binding to INamedTypeSymbol.ExtensionParameter.
Risk
Low - the new version matches what is shipped with the 10.0.1xx SDK, so with this change we are ensuring that we build against a version compatible with that used at runtime.