fix seq points assert check read on in mono#124563
Closed
FixBo wants to merge 1 commit into
Closed
Conversation
FixBo
requested review from
steveisok,
thaystg and
vitek-karas
as code owners
dotnet-policy-service
Bot
added
the
community-contribution
FixBo
changed the title
FixBo
changed the title
Contributor
Author
Member
|
Good catch. It was originally added 11 years ago mono/mono@91553a5 (I only fixed warning previously, didn't changed the order). |
Member
|
@FixBo I appreciate the contribution. The fix is definitely reasonable and one under regular conditions would go in easily. We have set the bar very high for mono fixes and unfortunately, we won't be able to take this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fread returns the number of elements read, not the number of bytes.
So the check of g_assert (len == fsize is incorrect