Skip to content

Clean up SkipUnresolved handling in linker test framework. #124972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbomer merged 1 commit into from
Mar 2, 2026
Merged

Clean up SkipUnresolved handling in linker test framework. #124972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ls/illink/test/Mono.Linker.Tests.Cases/Attributes/CoreLibraryAssemblyAttributesAreKept.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace Mono.Linker.Tests.Cases.Attributes
[SetupLinkerTrimMode("link")]
// System.dll referenced by a dynamically (for example in TypeConverterAttribute on IComponent)
// has unresolved references.
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[KeptAttributeInAssembly(PlatformAssemblies.CoreLib, typeof(AssemblyDescriptionAttribute))]
[KeptAttributeInAssembly(PlatformAssemblies.CoreLib, typeof(AssemblyCompanyAttribute))]
#if !NET
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/test/Mono.Linker.Tests.Cases/Attributes/IVTUsed.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ namespace Mono.Linker.Tests.Cases.Attributes

// This is a bit fragile but it's used to test that ITV attribute is marked correctly
[SetupLinkerTrimMode("link")]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[KeptTypeInAssembly(PlatformAssemblies.CoreLib, typeof(InternalsVisibleToAttribute))]
class IVTUsed
{
Expand Down
2 changes: 1 addition & 1 deletion ....Linker.Tests.Cases/Attributes/OnlyKeepUsed/UnusedAttributeOnGenericParameterIsRemoved.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace Mono.Linker.Tests.Cases.Attributes.OnlyKeepUsed
{
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[SetupLinkerArgument("--used-attrs-only", "true")]
[Define("IL_ASSEMBLY_AVAILABLE")]
[SetupCompileBefore("library.dll", new[] { "Dependencies/AssemblyWithUnusedAttributeOnGenericParameter.il" })]
Expand Down
2 changes: 1 addition & 1 deletion ...t/Mono.Linker.Tests.Cases/Attributes/OnlyKeepUsed/UnusedAttributeOnReturnTypeIsRemoved.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace Mono.Linker.Tests.Cases.Attributes.OnlyKeepUsed
{
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[SetupLinkerArgument("--used-attrs-only", "true")]
[Define("IL_ASSEMBLY_AVAILABLE")]
[SetupCompileBefore("library.dll", new[] { "Dependencies/AssemblyWithUnusedAttributeOnReturnParameterDefinition.il" })]
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/test/Mono.Linker.Tests.Cases/ComponentModel/CustomTypeConvertor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo c
[Reference("System.dll")]
// System.dll referenced by a dynamically (for example in TypeConverterAttribute on IComponent)
// has unresolved references.
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
public class CustomTypeConvertor
{
public static void Main()
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/test/Mono.Linker.Tests.Cases/CppCLI/CppCLIAssemblyIsAnalyzed.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace Mono.Linker.Tests.Cases.CppCLI
{
[IgnoreTestCase("Test relies on checked-in binaries: https://github.com/dotnet/runtime/issues/78344")]
[ReferenceDependency("Dependencies/TestLibrary.dll")]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]

[SetupCompileBefore("ManagedSide.dll", new[] { "Dependencies/CallCppCLIFromManagedRef.cs" })]
[SetupCompileAfter("ManagedSide.dll", new[] { "Dependencies/CallCppCLIFromManaged.cs" }, references: new[] { "TestLibrary.dll" })]
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/test/Mono.Linker.Tests.Cases/CppCLI/NonCopyActionWarnOnCppCLI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace Mono.Linker.Tests.Cases.CppCLI
{
[IgnoreTestCase("Test relies on checked-in binaries: https://github.com/dotnet/runtime/issues/78344")]
[ReferenceDependency("Dependencies/TestLibrary.dll")]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]

[SetupLinkerDefaultAction("copy")]
[SetupLinkerAction("copyused", "TestLibrary")]
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/UnresolvedMembers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ namespace Mono.Linker.Tests.Cases.DataFlow
// it would fail to JIT/run anyway.

[SkipILVerify]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[SetupCompileBefore("UnresolvedLibrary.dll", new[] { "Dependencies/UnresolvedLibrary.cs" }, removeFromLinkerInput: true)]
[ExpectedNoWarnings]
class UnresolvedMembers
Expand Down
2 changes: 1 addition & 1 deletion ...ink/test/Mono.Linker.Tests.Cases/DynamicDependencies/DynamicDependencyMethodInAssembly.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace Mono.Linker.Tests.Cases.DynamicDependencies
[KeptMemberInAssembly("library.dll", "Mono.Linker.Tests.Cases.DynamicDependencies.Dependencies.DynamicDependencyMethodInAssemblyLibrary", ".ctor()")]
[KeptMemberInAssembly("library.dll", "Mono.Linker.Tests.Cases.DynamicDependencies.Dependencies.DynamicDependencyMethodInAssemblyLibrary", "privateField")]
[SetupCompileBefore("library.dll", new[] { "Dependencies/DynamicDependencyMethodInAssemblyLibrary.cs" })]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
public class DynamicDependencyMethodInAssembly
{
public static void Main()
Expand Down
2 changes: 1 addition & 1 deletion ...s.Cases/Inheritance.Interfaces/DefaultInterfaceMethods/DimProvidedByRecursiveInterface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace Mono.Linker.Tests.Cases.Inheritance.Interfaces.DefaultInterfaceMethods
{
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[TestCaseRequirements(TestRunCharacteristics.SupportsDefaultInterfaceMethods, "Requires support for default interface methods")]
[Define("IL_ASSEMBLY_AVAILABLE")]
[SetupCompileBefore("library.dll", new[] { "Dependencies/DimProvidedByRecursiveInterface.il" })]
Expand Down
2 changes: 1 addition & 1 deletion .../Inheritance.Interfaces/DefaultInterfaceMethods/InterfaceWithAttributeOnImplementation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace Mono.Linker.Tests.Cases.Inheritance.Interfaces.DefaultInterfaceMethods
{
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[TestCaseRequirements(TestRunCharacteristics.SupportsDefaultInterfaceMethods, "Requires support for default interface methods")]
[Define("IL_ASSEMBLY_AVAILABLE")]
[SetupCompileBefore("library.dll", new[] { "Dependencies/InterfaceWithAttributeOnImpl.il" })]
Expand Down
2 changes: 1 addition & 1 deletion ...nheritance.Interfaces/DefaultInterfaceMethods/MultipleDimsProvidedByRecursiveInterface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace Mono.Linker.Tests.Cases.Inheritance.Interfaces.DefaultInterfaceMethods
{
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[TestCaseRequirements(TestRunCharacteristics.SupportsDefaultInterfaceMethods, "Requires support for default interface methods")]
[Define("IL_ASSEMBLY_AVAILABLE")]
[SetupCompileBefore("library.dll", new[] { "Dependencies/MultipleDimsProvidedByRecursiveInterface.il" })]
Expand Down
2 changes: 1 addition & 1 deletion ...nce.Interfaces/DefaultInterfaceMethods/StaticDimProvidedByUnreferencedIfaceInHierarchy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace Mono.Linker.Tests.Cases.Inheritance.Interfaces.DefaultInterfaceMethods
{
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[TestCaseRequirements(TestRunCharacteristics.SupportsDefaultInterfaceMethods, "Requires support for default interface methods")]
[Define("IL_ASSEMBLY_AVAILABLE")]
[SetupCompileBefore("library.dll", new[] { "Dependencies/StaticDimProvidedByUnreferencedIfaceInHierarchy.il" })]
Expand Down
2 changes: 1 addition & 1 deletion ...ono.Linker.Tests.Cases/Inheritance.Interfaces/InterfaceImplementedThroughBaseInterface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

namespace Mono.Linker.Tests.Cases.Inheritance.Interfaces
{
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[SetupLinkerArgument("-a", "test.exe", "library")]
[SetupLinkerArgument("-a", "library.dll", "library")]
[TestCaseRequirements(TestRunCharacteristics.SupportsDefaultInterfaceMethods, "Requires support for default interface methods")]
Expand Down
2 changes: 1 addition & 1 deletion ...ritance.Interfaces/OnReferenceType/NoInstanceCtor/NoInstanceCtorAndAssemblyPreserveAll.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace Mono.Linker.Tests.Cases.Inheritance.Interfaces.OnReferenceType.NoInstanceCtor
{
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]

[SetupCompileBefore("library.dll", new[] { "Dependencies/NoInstanceCtorAndAssemblyPreserveAll_Lib.il" })]
[KeptInterfaceOnTypeInAssemblyAttribute("library",
Expand Down
2 changes: 1 addition & 1 deletion ...Inheritance.Interfaces/OnReferenceType/NoInstanceCtor/NoInstanceCtorAndTypePreserveAll.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace Mono.Linker.Tests.Cases.Inheritance.Interfaces.OnReferenceType.NoInstanceCtor
{
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[SetupCompileBefore("library.dll", new[] { "Dependencies/NoInstanceCtorAndAssemblyPreserveAll_Lib.il" })]
[KeptInterfaceOnTypeInAssembly("library",
"Mono.Linker.Tests.Cases.Inheritance.Interfaces.OnReferenceType.NoInstanceCtor.Dependencies.NoInstanceCtorAndAssemblyPreserveAll_Lib/A",
Expand Down
2 changes: 1 addition & 1 deletion ...eritance.Interfaces/OnReferenceType/NoInstanceCtor/NoInstanceCtorAndTypePreserveFields.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace Mono.Linker.Tests.Cases.Inheritance.Interfaces.OnReferenceType.NoInstanceCtor
{
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[SetupCompileBefore("library.dll", new[] { "Dependencies/NoInstanceCtorAndAssemblyPreserveAll_Lib.il" })]

// The interfaces should be removed because the interface types are not marked
Expand Down
2 changes: 1 addition & 1 deletion ...OnReferenceType/NoInstanceCtor/NoInstanceCtorAndTypePreserveFieldsWithInterfacesMarked.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace Mono.Linker.Tests.Cases.Inheritance.Interfaces.OnReferenceType.NoInstanceCtor
{
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[Define("IL_ASSEMBLY_COMPILED")]
[SetupCompileBefore("library.dll", new[] { "Dependencies/NoInstanceCtorAndAssemblyPreserveAll_Lib.il" })]

Expand Down
2 changes: 1 addition & 1 deletion ...ritance.Interfaces/OnReferenceType/NoInstanceCtor/NoInstanceCtorAndTypePreserveMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace Mono.Linker.Tests.Cases.Inheritance.Interfaces.OnReferenceType.NoInstanceCtor
{
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[SetupCompileBefore("library.dll", new[] { "Dependencies/NoInstanceCtorAndAssemblyPreserveAll_Lib.il" })]

// The interfaces should be removed because the interface types are not marked
Expand Down
2 changes: 1 addition & 1 deletion ...nReferenceType/NoInstanceCtor/NoInstanceCtorAndTypePreserveMethodsWithInterfacesMarked.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace Mono.Linker.Tests.Cases.Inheritance.Interfaces.OnReferenceType.NoInstanceCtor
{
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[Define("IL_ASSEMBLY_COMPILED")]
[SetupCompileBefore("library.dll", new[] { "Dependencies/NoInstanceCtorAndAssemblyPreserveAll_Lib.il" })]

Expand Down
2 changes: 1 addition & 1 deletion ...nheritance.Interfaces/OnReferenceType/NoInstanceCtor/NoInstanceCtorAndTypePreserveNone.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace Mono.Linker.Tests.Cases.Inheritance.Interfaces.OnReferenceType.NoInstanceCtor
{
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[SetupCompileBefore("library.dll", new[] { "Dependencies/NoInstanceCtorAndAssemblyPreserveAll_Lib.il" })]
[RemovedInterfaceOnTypeInAssembly("library",
"Mono.Linker.Tests.Cases.Inheritance.Interfaces.OnReferenceType.NoInstanceCtor.Dependencies.NoInstanceCtorAndAssemblyPreserveAll_Lib/A",
Expand Down
2 changes: 1 addition & 1 deletion ...ases/Inheritance.Interfaces/RecursiveInterfaces/GenericInterfaceImplementedRecursively.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

namespace Mono.Linker.Tests.Cases.Inheritance.Interfaces.RecursiveInterfaces
{
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[TestCaseRequirements(TestRunCharacteristics.SupportsDefaultInterfaceMethods, "Requires support for default interface methods")]
[Define("IL_ASSEMBLY_AVAILABLE")]
[SetupCompileBefore("library.dll", new[] { "Dependencies/GenericInterfaceImplementedRecursively.il" })]
Expand Down
2 changes: 1 addition & 1 deletion ...Tests.Cases/Inheritance.Interfaces/RecursiveInterfaces/InterfaceImplementedRecursively.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

namespace Mono.Linker.Tests.Cases.Inheritance.Interfaces.RecursiveInterfaces
{
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[TestCaseRequirements(TestRunCharacteristics.SupportsDefaultInterfaceMethods, "Requires support for default interface methods")]
[Define("IL_ASSEMBLY_AVAILABLE")]
[SetupCompileBefore("library.dll", new[] { "Dependencies/InterfaceImplementedRecursively.il" })]
Expand Down
2 changes: 1 addition & 1 deletion ...Cases/Inheritance.Interfaces/RecursiveInterfaces/OverrideOfRecursiveInterfaceIsRemoved.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

namespace Mono.Linker.Tests.Cases.Inheritance.Interfaces.RecursiveInterfaces
{
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[Define("IL_ASSEMBLY_AVAILABLE")]
[SetupCompileBefore("library.dll", new string[] { "Dependencies/OverrideOfRecursiveInterfaceIsRemoved.il" })]
[Kept]
Expand Down
2 changes: 1 addition & 1 deletion ....Cases/Inheritance.Interfaces/StaticInterfaceMethods/InstanceMethodsWithOverridesSwept.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ namespace Mono.Linker.Tests.Cases.Inheritance.Interfaces.StaticInterfaceMethods
/// Currently, the linker will always mark the .override method for instance methods, so there is not much testing required here.
/// However, if that were to change, this test should be updated to verify that the .override is removed if the .interfaceImpl is kept.
/// </summary>
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[Define("IL_ASSEMBLY_AVAILABLE")]
[SetupCompileBefore("library.dll", new string[] { "Dependencies/InstanceMethods.il" })]
[Kept]
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/test/Mono.Linker.Tests.Cases/Libraries/LibraryWithUnresolvedInterfaces.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace Mono.Linker.Tests.Cases.Libraries
[IgnoreTestCase("NativeAOT doesn't implement library trimming the same way", IgnoredBy = Tool.NativeAot)]
[KeptAttributeAttribute(typeof(IgnoreTestCaseAttribute), By = Tool.Trimmer)]
[SetupCompileBefore("copylibrary.dll", new[] { "Dependencies/CopyLibrary.cs" }, removeFromLinkerInput: true)]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[SetupLinkerArgument("-a", "test.exe", "library")]
[SetupLinkerArgument("--enable-opt", "ipconstprop")]
[VerifyMetadataNames]
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/test/Mono.Linker.Tests.Cases/LinkAttributes/LinkAttributeErrorCases.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace Mono.Linker.Tests.Cases.LinkAttributes
{
[SetupLinkAttributesFile("LinkAttributeErrorCases.xml")]
[IgnoreLinkAttributes(false)]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[SetupCompileBefore("library.dll", new string[] { "Dependencies/EmbeddedAttributeErrorCases.cs" },
resources: new object[] { new string[] { "Dependencies/EmbeddedAttributeErrorCases.xml", "ILLink.LinkAttributes.xml" } })]

Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/test/Mono.Linker.Tests.Cases/LinkXml/LinkXmlErrorCases.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Mono.Linker.Tests.Cases.LinkXml
{
[SetupLinkerDescriptorFile("LinkXmlErrorCases.xml")]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[SetupLinkerArgument("--verbose")]

[ExpectedWarning("IL2001", "TypeWithNoFields", FileName = "LinkXmlErrorCases.xml", SourceLine = 3, SourceColumn = 6)]
Expand Down
2 changes: 1 addition & 1 deletion .../illink/test/Mono.Linker.Tests.Cases/PreserveDependencies/PreserveDependencyErrorCases.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Mono.Linker.Tests.Cases.PreserveDependencies
{
[SetupCompileBefore("FakeSystemAssembly.dll", new[] { "Dependencies/PreserveDependencyAttribute.cs" })]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
class PreserveDependencyErrorCases
{
public static void Main()
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/test/Mono.Linker.Tests.Cases/References/Individual/CanSkipUnresolved.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Mono.Linker.Tests.Cases.References.Individual
{
[SetupCompileBefore("library1.dll", new[] { "Dependencies/CanSkipUnresolved_Library.cs" })]
[SetupCompileAfter("library1.dll", new[] { "Dependencies/CanSkipUnresolved_Library.cs" }, defines: new[] { "EXCLUDE_STUFF" })]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
public class CanSkipUnresolved
{
static void Main()
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/test/Mono.Linker.Tests.Cases/References/MissingReferenceInUnusedCodePath.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace Mono.Linker.Tests.Cases.References;
[NoLinkedOutput]
[SetupCompileBefore("missing.dll", new[] { "Dependencies/MissingAssembly.cs" })]
[DeleteBefore("missing.dll")]
[SetupLinkerArgument("--skip-unresolved", "false")]
[SkipUnresolved(false)]
public class MissingReferenceInUnusedCodePath
{
public static void Main()
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/test/Mono.Linker.Tests.Cases/References/MissingReferenceInUsedCodePath.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace Mono.Linker.Tests.Cases.References;
[NoLinkedOutput]
[SetupCompileBefore("missing.dll", new[] { "Dependencies/MissingAssembly.cs" })]
[DeleteBefore("missing.dll")]
[SetupLinkerArgument("--skip-unresolved", "false")]
[SkipUnresolved(false)]
public class MissingReferenceInUsedCodePath
{
public static void Main()
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/test/Mono.Linker.Tests.Cases/Symbols/ReferenceWithMdb.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Mono.Linker.Tests.Cases.Symbols
{
[IgnoreTestCase("Test relies on checked-in binaries: https://github.com/dotnet/runtime/issues/78344")]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[Reference("Dependencies/LibraryWithMdb/LibraryWithMdb.dll")]
[ReferenceDependency("Dependencies/LibraryWithMdb/LibraryWithMdb.dll.mdb")]
[SetupLinkerLinkSymbols("false")]
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/test/Mono.Linker.Tests.Cases/Symbols/ReferenceWithMdbCopyAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Mono.Linker.Tests.Cases.Symbols
{
[IgnoreTestCase("Test relies on checked-in binaries: https://github.com/dotnet/runtime/issues/78344")]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[Reference("Dependencies/LibraryWithMdb/LibraryWithMdb.dll")]
[ReferenceDependency("Dependencies/LibraryWithMdb/LibraryWithMdb.dll.mdb")]
[SetupLinkerLinkSymbols("false")]
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/test/Mono.Linker.Tests.Cases/Symbols/ReferenceWithMdbDeleteAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Mono.Linker.Tests.Cases.Symbols
{
[IgnoreTestCase("Test relies on checked-in binaries: https://github.com/dotnet/runtime/issues/78344")]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[Reference("Dependencies/LibraryWithMdb/LibraryWithMdb.dll")]
[ReferenceDependency("Dependencies/LibraryWithMdb/LibraryWithMdb.dll.mdb")]
[SetupLinkerLinkSymbols("false")]
Expand Down
2 changes: 1 addition & 1 deletion ...st/Mono.Linker.Tests.Cases/Symbols/ReferenceWithMdbDeleteActionAndSymbolLinkingEnabled.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Mono.Linker.Tests.Cases.Symbols
{
[IgnoreTestCase("Test relies on checked-in binaries: https://github.com/dotnet/runtime/issues/78344")]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[Reference("Dependencies/LibraryWithMdb/LibraryWithMdb.dll")]
[ReferenceDependency("Dependencies/LibraryWithMdb/LibraryWithMdb.dll.mdb")]
[SetupLinkerLinkSymbols("true")]
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/test/Mono.Linker.Tests.Cases/Symbols/ReferenceWithPdb.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Mono.Linker.Tests.Cases.Symbols
{
[IgnoreTestCase("Test relies on checked-in binaries: https://github.com/dotnet/runtime/issues/78344")]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[Reference("Dependencies/LibraryWithPdb/LibraryWithPdb.dll")]
[ReferenceDependency("Dependencies/LibraryWithPdb/LibraryWithPdb.pdb")]
[SetupLinkerLinkSymbols("false")]
Expand Down
2 changes: 1 addition & 1 deletion ...ls/illink/test/Mono.Linker.Tests.Cases/Symbols/ReferenceWithPdbAndSymbolLinkingEnabled.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Mono.Linker.Tests.Cases.Symbols
{
[IgnoreTestCase("Test relies on checked-in binaries: https://github.com/dotnet/runtime/issues/78344")]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[Reference("Dependencies/LibraryWithPdb/LibraryWithPdb.dll")]
[ReferenceDependency("Dependencies/LibraryWithPdb/LibraryWithPdb.pdb")]
[SetupLinkerLinkSymbols("true")]
Expand Down
2 changes: 1 addition & 1 deletion ...Linker.Tests.Cases/Symbols/ReferenceWithPdbAndSymbolLinkingEnabledAndDeterministicMvid.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Mono.Linker.Tests.Cases.Symbols
{
[IgnoreTestCase("Test relies on checked-in binaries: https://github.com/dotnet/runtime/issues/78344")]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[Reference("Dependencies/LibraryWithPdb/LibraryWithPdb.dll")]
[ReferenceDependency("Dependencies/LibraryWithPdb/LibraryWithPdb.pdb")]
[SetupLinkerLinkSymbols("true")]
Expand Down
2 changes: 1 addition & 1 deletion ...test/Mono.Linker.Tests.Cases/Symbols/ReferenceWithPdbAndSymbolLinkingEnabledAndNewMvid.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Mono.Linker.Tests.Cases.Symbols
{
[IgnoreTestCase("Test relies on checked-in binaries: https://github.com/dotnet/runtime/issues/78344")]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[Reference("Dependencies/LibraryWithPdb/LibraryWithPdb.dll")]
[ReferenceDependency("Dependencies/LibraryWithPdb/LibraryWithPdb.pdb")]
[SetupLinkerLinkSymbols("true")]
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/test/Mono.Linker.Tests.Cases/Symbols/ReferenceWithPdbCopyAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Mono.Linker.Tests.Cases.Symbols
{
[IgnoreTestCase("Test relies on checked-in binaries: https://github.com/dotnet/runtime/issues/78344")]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[Reference("Dependencies/LibraryWithPdb/LibraryWithPdb.dll")]
[ReferenceDependency("Dependencies/LibraryWithPdb/LibraryWithPdb.pdb")]
[SetupLinkerLinkSymbols("false")]
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/test/Mono.Linker.Tests.Cases/Symbols/ReferenceWithPdbDeleteAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Mono.Linker.Tests.Cases.Symbols
{
[IgnoreTestCase("Test relies on checked-in binaries: https://github.com/dotnet/runtime/issues/78344")]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[Reference("Dependencies/LibraryWithPdb/LibraryWithPdb.dll")]
[ReferenceDependency("Dependencies/LibraryWithPdb/LibraryWithPdb.pdb")]
[SetupLinkerLinkSymbols("false")]
Expand Down
2 changes: 1 addition & 1 deletion ...st/Mono.Linker.Tests.Cases/Symbols/ReferenceWithPdbDeleteActionAndSymbolLinkingEnabled.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Mono.Linker.Tests.Cases.Symbols
{
[IgnoreTestCase("Test relies on checked-in binaries: https://github.com/dotnet/runtime/issues/78344")]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[Reference("Dependencies/LibraryWithPdb/LibraryWithPdb.dll")]
[ReferenceDependency("Dependencies/LibraryWithPdb/LibraryWithPdb.pdb")]
[SetupLinkerLinkSymbols("true")]
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/test/Mono.Linker.Tests.Cases/Symbols/ReferencesWithMixedSymbolTypes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Mono.Linker.Tests.Cases.Symbols
{
[IgnoreTestCase("Test relies on checked-in binaries: https://github.com/dotnet/runtime/issues/78344")]
[SetupLinkerArgument("--skip-unresolved", "true")]
[SkipUnresolved(true)]
[Reference("Dependencies/LibraryWithMdb/LibraryWithMdb.dll")]
[ReferenceDependency("Dependencies/LibraryWithMdb/LibraryWithMdb.dll.mdb")]

Expand Down
Loading
Loading