Conversation
There was a problem hiding this comment.
Pull request overview
Fixes getdomainname() availability on SunOS so System.Net.NetworkInformation.Functional.Tests can run without aborting, by correctly detecting and linking the required SunOS libraries and adding a missing declaration.
Changes:
- Update CMake configuration to detect
getdomainnameon SunOS viacheck_function_existswhile linking againstsocket/nsl. - Add an explicit
getdomainnameprototype for SunOS builds where no header declares it. - Link
System.Nativeagainstlibnslon SunOS.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/native/libs/configure.cmake | SunOS-specific getdomainname detection with required link libraries and restoration of CMAKE_REQUIRED_LIBRARIES. |
| src/native/libs/System.Native/pal_networking.c | Adds SunOS-only getdomainname forward declaration when the function is available. |
| src/native/libs/System.Native/extra_libs.cmake | Ensures System.Native links socket and nsl on SunOS. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
You can also share your feedback on Copilot code review. Take the survey.
The tests (System.Net.NetworkInformation.Functional.Tests) being used to validate the work in #124728 need getdomainname() to work or else the test will abort and dump core. This fixes that for SunOS.