Implement UnknownSizeFrame for locals with unknown size#125491
Open
snickolls-arm wants to merge 5 commits intodotnet:mainfrom
Open
Implement UnknownSizeFrame for locals with unknown size#125491snickolls-arm wants to merge 5 commits intodotnet:mainfrom
snickolls-arm wants to merge 5 commits intodotnet:mainfrom
Conversation
Implements a simple bump allocator for TYP_SIMD and TYP_MASK. Locals are allocated to this space when lvaIsUnknownSizeLocal is true for the variable. The frame is implemented on ARM64 as two homogenenous blocks containing either TYP_SIMD or TYP_MASK locals. The x19 register is reserved for addressing locals in the block. Updates codegen for SVE memory transfer instructions to accept indices in multiples of the vector length (or VL / 8 for masks) instead of deriving them from the size of the local.
github-actions
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
10 tasks
This was referenced Mar 12, 2026
Open
Contributor
Author
|
Looking at the throughput differences, the performance of |
jakobbotsch
reviewed
Mar 23, 2026
jakobbotsch
reviewed
Mar 23, 2026
jakobbotsch
reviewed
Mar 23, 2026
jakobbotsch
reviewed
Mar 23, 2026
jakobbotsch
reviewed
Mar 23, 2026
jakobbotsch
reviewed
Mar 23, 2026
* Add function header * Create UnknownSizeFrame::GetAddressingOffset and revert changes to lvaFrameAddress * Use rsSetRegsModified and remove kill ref position
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a simple bump allocator for
TYP_SIMDandTYP_MASK. Locals are allocated to this space whenlvaIsUnknownSizeLocalis true for the variable.The frame is implemented on ARM64 as two homogenenous blocks containing either
TYP_SIMDorTYP_MASKlocals. The x19 register is reserved for addressing locals in the block. Updates codegen for SVE memory transfer instructions to accept indices in multiples of the vector length (or VL / 8 for masks) instead of deriving them from the size of the local.