Skip to content

Fix ProcessThreadTests.TestStartTimeProperty flakiness due to /proc visibility race #125811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 4 commits into from
Mar 20, 2026
+10 −5
Merged

Fix ProcessThreadTests.TestStartTimeProperty flakiness due to /proc visibility race #125811

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b4db68
Initial plan
Copilot Mar 20, 2026
28a2e93
Fix ProcessThreadTests.TestStartTimeProperty race condition with retr…
Copilot Mar 20, 2026
b107dbf
Improve Assert message for thread-not-found failure case
Copilot Mar 20, 2026
8637f70
Address review feedback: platform-agnostic comment, use DateTime.UtcNow
danmoseley Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/libraries/System.Diagnostics.Process/tests/ProcessThreadTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,19 @@ public async Task TestStartTimeProperty()
// that there's at least one thread greater than the current time we previously grabbed.
await Task.Factory.StartNew(() =>
{
p.Refresh();

int newThreadId = GetCurrentThreadId();

ProcessThread[] processThreads = p.Threads.Cast<ProcessThread>().ToArray();
ProcessThread newThread = Assert.Single(processThreads, thread => thread.Id == newThreadId);
// Retry to handle the race where the newly started thread is not yet visible via Process.Threads.
ProcessThread newThread = null;
for (int i = 0; i < 10 && newThread is null; i++)
{
if (i > 0) Thread.Sleep(100);
p.Refresh();
newThread = p.Threads.Cast<ProcessThread>().FirstOrDefault(t => t.Id == newThreadId);
}

Assert.InRange(newThread.StartTime.ToUniversalTime(), curTime - allowedWindow, DateTime.Now.ToUniversalTime() + allowedWindow);
Assert.True(newThread is not null, $"Thread with id {newThreadId} was not found after retrying.");
Assert.InRange(newThread.StartTime.ToUniversalTime(), curTime - allowedWindow, DateTime.UtcNow + allowedWindow);
}, CancellationToken.None, TaskCreationOptions.LongRunning, TaskScheduler.Default);
}
}
Expand Down
Loading