Repository navigation
Inherit block weight in compare chain formation - #137029
Merged
AndyAyersMS merged 1 commit intoNov 7, 2026
Merged
Conversation
Forming a chain moves the first block's condition into the second and compacts the two, and compaction gives the combined block the second block's weight. The second block's only predecessor is the first and the edge between them becomes unconditional, so the combined block runs as often as the first block and inherits its weight.
dotnet-policy-service
Bot
added
the
community-contribution
github-actions
Bot
added
the
area-CodeGen-coreclr
|
Azure Pipelines: Successfully started running 5 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
NinoFloris
marked this pull request as ready for review
November 5, 2026 15:59
AndyAyersMS
approved these changes
Nov 7, 2026
Member
|
Thanks for fixing this. |
Contributor
Author
|
Thank you for the quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forming a chain moves the first block's condition into the second and compacts the two, and compaction gives the combined block the second block's weight. The second block's only predecessor is the first and the edge between them becomes unconditional, so the combined block runs as often as the first block and inherits its weight.
This showed up as some false positive perf score regressions in #136994 because a fold keeps the first block's weight while the chain logic on main only kept the second.
@AndyAyersMS