Repository navigation
[browser][coreclr] Add trimmed managed native flavors - #137440
Draft
pavelsavara wants to merge 3 commits into
Draft
pavelsavara wants to merge 3 commits into
pavelsavara wants to merge 3 commits into
Conversation
Build production and diagnostics shared-framework closures, generate flavor-specific interop helpers, and select matching managed and native assets without wasm-tools. Keep app publish trimming and workload relinking behavior unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
Generate and commit production and diagnostics call-helper tables, build separate native archives, and select them when prelinking browserhost. Keep the full framework helper archive for corerun and reserve dynamic generation for application relinking. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Nov 12, 2026
Preserve the complete framework implementation while applying EventSource substitutions, distinguish workload defaults from explicit settings, and defer flavor asset validation until runtime-pack selection. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Nov 14, 2026
Open
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnableDiagnosticsandEventSourceSupportas aliases for flavor selection without making either property independently trigger native relinking.This is a stacked draft on #137014 and should be reviewed and merged after that PR.
Validation
.\build.cmd -bl -os browser -subset clr+libs+host -c Debug /p:RuntimeFlavor=CoreCLR /p:EnableHotReloadInRuntimeConfigDevFile=false.\build.cmd -bl -os browser -subset clr+libs+host -c Release /p:RuntimeFlavor=CoreCLR /p:EnableHotReloadInRuntimeConfigDevFile=falseCoreClrPrelinkedNativeFlavorIsSelectedWithoutWorkloadTracingPropertySelectsNativeFlavorMicrosoft.NET.Sdk.WebAssemblyprojects.PropertyDifferentFromRuntimePackTriggersRelinkingCoreCLRWasmNativeDefaultsTestsIdnMappingIdnaConformanceTests.GetAscii_Successpassed in Chrome.StringTests.IndexOf_NullInStringsis correctly skipped when Browser uses ICU; the first CI run incorrectly selected NLS behavior and executed it.BlazorEventPipeTestWithCpuSamplesPrelinkedgit diff --check, MSBuild XML parsing, and conflict-marker checks passed.Release size comparison
Measurements are from the Release runtime-pack nupkg. Compressed values are the sum of the corresponding ZIP entry sizes.
dotnet.native.wasmSystem.Private.CoreLib.dllis 5,585,920 bytes in production and 5,600,768 bytes in diagnostics, a 14,848-byte difference.The two additional checked-in helper archives add 794,822 raw bytes and 266,760 nupkg-compressed bytes. The existing full helper archive remains for corerun compatibility.
Reviewer notes
EnableDiagnosticstoEventSourceSupportmigration is intentionally postponed.allroots so they preserve the complete runtime implementation while applying EventSource feature substitutions. Production and diagnostics expose the same complete helper surface; their managed method bodies differ.Note
This pull request description was generated with GitHub Copilot.