FileSystem.AccessControl tests not cleaning files properly#47074
Merged
carlossanlop merged 14 commits intodotnet:masterfrom Feb 9, 2021
carlossanlop:ACLTests
Merged
FileSystem.AccessControl tests not cleaning files properly#47074carlossanlop merged 14 commits intodotnet:masterfrom carlossanlop:ACLTests
carlossanlop merged 14 commits intodotnet:masterfrom
carlossanlop:ACLTests
Conversation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44766
The TempDirectory helper class is disposable. The finalizer calls a function that deletes the folders left behind, without throwing exceptions on fail.
This protective try catch hid some additional errors that were not caught when these unit tests were first written, so I'm fixing them: