Skip to content

[browser] Fix System.Delegate.DynamicInvoke method can not be resolved #47519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marek-safar merged 23 commits into from
Feb 10, 2021
Merged

[browser] Fix System.Delegate.DynamicInvoke method can not be resolved #47519

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
377a8e4
[browser] Fix System.Delegate.DynamicInvoke method can not be resolved
kjpou1 Jan 27, 2021
ddb0485
Address review comment for assembly name
kjpou1 Jan 27, 2021
84c0ba6
Change this back to mscorlib as the recommended code cause a warning.
kjpou1 Jan 27, 2021
e6e8d34
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
kjpou1 Jan 29, 2021
ab9ae20
[browser] Remove linker trim exclusions for System.Delegate.DynamicI…
kjpou1 Jan 29, 2021
2070cb5
Remove dependency on System.Delegate.DynamicInvoke
kjpou1 Jan 29, 2021
255be2f
Add method to retrieve the Invoke method of the delegate
kjpou1 Jan 29, 2021
7203cbf
Create another test module for Delegate tests
kjpou1 Jan 29, 2021
cbbcbd9
Add MarshalFunctionReturnAction that marshals an Action delegate from…
kjpou1 Jan 29, 2021
7145696
More tests, Actions and Delegate methods
kjpou1 Jan 29, 2021
fb8247d
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
kjpou1 Feb 1, 2021
1c65efd
Add multi cast tests
kjpou1 Feb 1, 2021
019c642
Add anon and lamda del test
kjpou1 Feb 1, 2021
7f964e9
Add tests for marshaling TypedArray from different delegates.
kjpou1 Feb 1, 2021
6a61e70
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
kjpou1 Feb 2, 2021
5571af1
Address review comment. Remove unused variable argsroot.
kjpou1 Feb 2, 2021
823b67c
Remove extra assert as per review
kjpou1 Feb 2, 2021
28db172
Address review of switched expected
kjpou1 Feb 2, 2021
58548c6
As per review comment Rename all Marshal method names to Invoke
kjpou1 Feb 2, 2021
81a375a
Add more array type tests for delegates.
kjpou1 Feb 2, 2021
a19b8ca
Combine Delegate tests and Multi Cast delegate tests
kjpou1 Feb 2, 2021
6ac1cb8
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
kjpou1 Feb 10, 2021
b1f78ad
Fix accessor after merge conflict
kjpou1 Feb 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/libraries/System.Private.Runtime.InteropServices.JavaScript/src/ILLink/ILLinkTrim.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,12 @@
<assembly fullname="System.Private.Runtime.InteropServices.JavaScript">
<type fullname="System.Runtime.InteropServices.JavaScript.Runtime" />
</assembly>
<!--
Preserve System.Delegate.DynamicInvoke which is called from javascript
Comment thread
kjpou1 marked this conversation as resolved.
Outdated
-->
<assembly fullname="mscorlib">
Comment thread
kjpou1 marked this conversation as resolved.
Outdated
<type fullname="System.Delegate">
<method signature="System.Object DynamicInvoke(System.Object[])" />
Comment thread
kjpou1 marked this conversation as resolved.
Outdated
</type>
</assembly>
</linker>