Skip to content

[iOS/tvOS] Fix TargetOS case-sensitivity in tests #50582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lambdageek merged 3 commits into from
Apr 2, 2021
Merged

[iOS/tvOS] Fix TargetOS case-sensitivity in tests #50582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32e5c31
Fix TargetOS case-sensitivity in tests
MaximLipnin Apr 1, 2021
646976a
Fix TargetOS in AppleAppBuilder
MaximLipnin Apr 1, 2021
3613581
Remove the switch
MaximLipnin Apr 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/tasks/AppleAppBuilder/AppleAppBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,24 @@

public class AppleAppBuilderTask : Task
{
private string targetOS = TargetNames.iOS;

/// <summary>
/// The Apple OS we are targeting (iOS or tvOS)
/// </summary>
[Required]
public string TargetOS { get; set; } = TargetNames.iOS;
public string TargetOS
{
get
{
return targetOS;
}

set
{
targetOS = value.ToLower();
}
}

/// <summary>
/// ProjectName is used as an app name, bundleId and xcode project name
Expand Down
10 changes: 5 additions & 5 deletions src/tasks/AppleAppBuilder/TargetOS.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@

internal static class TargetNames
{
public const string iOS = "iOS";
public const string iOSsim = "iOSSimulator";
public const string tvOS = "tvOS";
public const string tvOSsim = "tvOSSimulator";
public const string MacCatalyst = "MacCatalyst";
public const string iOS = "ios";
public const string iOSsim = "iossimulator";
public const string tvOS = "tvos";
public const string tvOSsim = "tvossimulator";
public const string MacCatalyst = "maccatalyst";
}