Skip to content

Add checking SpeechRecognitionEngine Culture to GrammarBuilder test#59516

Merged
danmoseley merged 2 commits intodotnet:mainfrom
AlexRadch:GrammarBuilderTestCulture
Sep 27, 2021
Merged

Add checking SpeechRecognitionEngine Culture to GrammarBuilder test#59516
danmoseley merged 2 commits intodotnet:mainfrom
AlexRadch:GrammarBuilderTestCulture

Conversation

@AlexRadch
Copy link
Copy Markdown
Contributor

Fix #59400 issue.

@ghost ghost added area-System.Speech community-contribution Indicates that the PR has been added by a community member labels Sep 23, 2021
@ghost
Copy link
Copy Markdown

ghost commented Sep 23, 2021

Tagging subscribers to this area: @danmoseley
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #59400 issue.

Author: AlexRadch
Assignees: -
Labels:

area-System.Speech

Milestone: -

Copy link
Copy Markdown
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works - great. Thanks @AlexRadch

@danmoseley
Copy link
Copy Markdown
Member

Looks like the test is failing.

@danmoseley
Copy link
Copy Markdown
Member

I have no idea why the exception is not thrown on some configurations. I'd be fine with just skipping the test if rec.RecognizerInfo.Culture != builder.Culture

@danmoseley
Copy link
Copy Markdown
Member

trying that

@danmoseley danmoseley merged commit 0d05e3e into dotnet:main Sep 27, 2021
@danmoseley
Copy link
Copy Markdown
Member

thank you !

@AlexRadch AlexRadch deleted the GrammarBuilderTestCulture branch September 28, 2021 02:28
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Speech community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System.Speech.Tests fail GrammarBuilder test on non-English OS

2 participants