Skip to content

prevent manifest sending for special cased event sources #60357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
josalem wants to merge 2 commits into from
Closed

prevent manifest sending for special cased event sources #60357

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cfa0f3
prevent manifest sending for special cased event sources
Oct 12, 2021
cc3dc06
Use numerical Guid constructor
Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2895,9 +2895,10 @@ private void EnsureDescriptorsInitialized()

// Send out the ETW manifest XML out to ETW
// Today, we only send the manifest to ETW, custom listeners don't get it.
// Don't send if we are specific "EventSource"s that are pass-throughs to native events
private unsafe void SendManifest(byte[]? rawManifest)
{
if (rawManifest == null)
if (rawManifest == null || m_guid.Equals(NativeRuntimeEventSourceGuid))
return;

Debug.Assert(!SelfDescribingEvents);
Expand Down Expand Up @@ -3961,6 +3962,9 @@ private bool SelfDescribingEvents
// used for generating GUID from eventsource name
private static byte[]? namespaceBytes;
#endif

// GUIDs for special-cased EventSources, e.g., NativeRuntimeEventSource, that shouldn't send a manifest to ETW
private static readonly Guid NativeRuntimeEventSourceGuid = new Guid("E13C0D23-CCBC-4E12-931B-D9CC2EEE27E4"); // NativeRuntimeEventSource
Comment thread
josalem marked this conversation as resolved.
Outdated
#endregion
}

Expand Down