Skip to content

[wasm] Rework fetch #61639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lewing merged 8 commits into from
Nov 16, 2021
Merged

[wasm] Rework fetch #61639

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2178a57
Unify some code
lewing Nov 15, 2021
8eb230a
Work around v8 not having a nice way to convert to string
lewing Nov 16, 2021
c7bef9e
redo naming and formatting
lewing Nov 16, 2021
3b2e5ce
do it all aync
lewing Nov 16, 2021
d9438a4
Trap more exceptions again and drop _get_fetch_implmentation
lewing Nov 16, 2021
e8e2982
Fix the type definitions for UTF8ArrayToString
lewing Nov 16, 2021
07c6f90
Fix accidental sync call
lewing Nov 16, 2021
3bfbd66
Remove TypedArray import
lewing Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 28 additions & 27 deletions src/mono/wasm/runtime/startup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,26 +57,36 @@ export function mono_wasm_set_runtime_options(options: string[]): void {
}

async function _fetch_asset(url: string): Promise<Response> {
if (typeof (fetch) === "function") {
return fetch(url, { credentials: "same-origin" });
}
else if (ENVIRONMENT_IS_NODE) {
// eslint-disable-next-line @typescript-eslint/no-var-requires
const fs = require("fs");
const arrayBuffer = await fs.readFileSync(url);
return <Response><any> {
ok: true,
url,
arrayBuffer: () => arrayBuffer,
json: () => JSON.parse(arrayBuffer)
};
try {
if (typeof (fetch) === "function") {
return fetch(url, { credentials: "same-origin" });
}
else if (ENVIRONMENT_IS_NODE) {
// eslint-disable-next-line @typescript-eslint/no-var-requires
const fs = require("fs");
Copy link
Copy Markdown
Member

@pavelsavara pavelsavara Nov 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will do require for each call of the _fetch_asset. I admit the previous implementation had the same issue.

const arrayBuffer = await fs.readFileSync(url);
return <Response><any> {
ok: true,
url,
arrayBuffer: () => arrayBuffer,
json: () => JSON.parse(arrayBuffer)
};
}
else if (typeof (read) === "function") {
return <Response><any> {
ok: true,
url,
arrayBuffer: () => new Uint8Array(read(url, "binary")),
json: () => JSON.parse(read(url))
};
}
}
else if (typeof (read) === "function") {
catch (e) {
return <Response><any> {
ok: true,
ok: false,
Copy link
Copy Markdown
Member

@kg kg Nov 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe store the error as a property so the caller can find out what the error was without an extra throw+catch

url,
arrayBuffer: () => new Uint8Array(read(url, "binary")),
json: () => JSON.parse(read(url))
arrayBuffer: () => { throw e; },
json: () => { throw e; }
};
}
throw new Error("No fetch implementation available");
Expand Down Expand Up @@ -169,15 +179,6 @@ function _apply_configuration_from_args(args: MonoConfig) {
mono_wasm_init_coverage_profiler(args.coverage_profiler_options);
}

function _get_fetch_implementation(args: MonoConfig): (asset: string) => Promise<Response> {
if (typeof (args.fetch_file_cb) === "function")
return args.fetch_file_cb;

return function (asset) {
return _fetch_asset(asset);
};
}

function _finalize_startup(args: MonoConfig, ctx: MonoInitContext) {
const moduleExt = Module as EmscriptenModuleMono;

Expand Down Expand Up @@ -310,7 +311,7 @@ export async function mono_load_runtime_and_bcl_args(args: MonoConfig): Promise<

_apply_configuration_from_args(args);

const local_fetch = _get_fetch_implementation(args);
const local_fetch = typeof (args.fetch_file_cb) === "function" ? args.fetch_file_cb : _fetch_asset;
Comment thread
pavelsavara marked this conversation as resolved.

const load_asset = async (asset: AllAssetEntryTypes): Promise<void> => {
//TODO we could do module.addRunDependency(asset.name) and delay emscripten run() after all assets are loaded
Expand Down