Use the right format of bkpt/brk for align that falls after jump#62106
Merged
kunalspathak merged 4 commits intodotnet:mainfrom Nov 30, 2021
Merged
Use the right format of bkpt/brk for align that falls after jump#62106kunalspathak merged 4 commits intodotnet:mainfrom
kunalspathak merged 4 commits intodotnet:mainfrom
Conversation
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue Detailsnull
|
kunalspathak
changed the title
kunalspathak
changed the title
Contributor
Author
|
@dotnet/jit-contrib |
BruceForstall
approved these changes
Nov 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GDB expects the
brkinstruction to bebrk #0on Linux and windows debugger expectbrk #F000on Windows. Although the immediate is different, both are of formbrk #immediatewhich are of same format. We were having outdatedbkptinstruction name forbrk #F000encoding. Instead rename it tobrk_windowsandbrk_unixto clearly distinguish the two.See discussion in #61944 (comment).
This also fixes an issue where we would accidently (under stress mode) emit
brkinstruction for analignthat is not placed afterjmp. Example in #61944 (comment)Fixes: #61944, #61824