Skip to content

[Mono] Add SIMD intrinsic for Vector64/128 comparisons #65128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonrozsival merged 15 commits into from
Feb 25, 2022
Merged

[Mono] Add SIMD intrinsic for Vector64/128 comparisons #65128

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
dd0b05a
Add vector comparison intrinsics
simonrozsival Feb 10, 2022
e397416
Add EqualsAll and EqualsAny intrinsics
simonrozsival Feb 11, 2022
7c9dc2a
Merge branch 'main' into vector-intrinsics-eq-gt-geq-lt-leq
simonrozsival Feb 11, 2022
6d01474
Remove broken EqualsAny
simonrozsival Feb 14, 2022
9434cf9
Fix EqualsAny
simonrozsival Feb 15, 2022
c6882fe
Merge branch 'main' of https://github.com/dotnet/runtime into vector-…
simonrozsival Feb 15, 2022
9120f8e
Enable xequal also for arm64
simonrozsival Feb 22, 2022
ba3b3e2
Fix xzero type
simonrozsival Feb 22, 2022
0cd0a3a
Merge branch 'main' into vector-intrinsics-eq-gt-geq-lt-leq
simonrozsival Feb 22, 2022
ed8f56b
Fix bad merge
simonrozsival Feb 22, 2022
a35683b
Add guards for invalid types
simonrozsival Feb 23, 2022
82a7672
Revert unrelated change
simonrozsival Feb 24, 2022
862cda9
Extract duplicate code blocks to a new function
simonrozsival Feb 24, 2022
20113c3
Fix EqualsAny
simonrozsival Feb 24, 2022
1c0f52d
Fix typo + code improvements
simonrozsival Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions src/mono/mono/mini/simd-intrinsics.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,12 @@ emit_xequal (MonoCompile *cfg, MonoClass *klass, MonoInst *arg1, MonoInst *arg2)
return emit_simd_ins (cfg, klass, OP_XEQUAL, arg1->dreg, arg2->dreg);
}

static MonoInst*
emit_xzero (MonoCompile *cfg, MonoClass *klass)
{
return emit_simd_ins (cfg, klass, OP_XZERO, -1, -1);
}

static gboolean
is_intrinsics_vector_type (MonoType *vector_type)
{
Expand Down Expand Up @@ -498,7 +504,7 @@ emit_vector_create_elementwise (
{
int op = type_to_insert_op (etype);
MonoClass *vklass = mono_class_from_mono_type_internal (vtype);
MonoInst *ins = emit_simd_ins (cfg, vklass, OP_XZERO, -1, -1);
MonoInst *ins = emit_xzero (cfg, vklass);
for (int i = 0; i < fsig->param_count; ++i) {
ins = emit_simd_ins (cfg, vklass, op, ins->dreg, args [i]->dreg);
ins->inst_c0 = i;
Expand Down Expand Up @@ -595,8 +601,10 @@ static guint16 sri_vector_methods [] = {
SN_Create,
SN_CreateScalar,
SN_CreateScalarUnsafe,
SN_Divide,
SN_Equals,
SN_EqualsAll,
SN_EqualsAny,
SN_Floor,
SN_GetElement,
SN_GetLower,
Expand All @@ -605,9 +613,11 @@ static guint16 sri_vector_methods [] = {
SN_GreaterThanOrEqual,
SN_LessThan,
SN_LessThanOrEqual,
SN_Max,
SN_Multiply,
SN_Subtract,
SN_ToScalar,
SN_ToVector128,
SN_ToVector128Unsafe,
SN_ToVector256,
SN_ToVector256Unsafe,
SN_WithElement,
Expand Down Expand Up @@ -796,6 +806,16 @@ emit_sri_vector (MonoCompile *cfg, MonoMethod *cmethod, MonoMethodSignature *fsi
return emit_xcompare (cfg, klass, arg0_type, args [0], args [1]);
case SN_EqualsAll:
return emit_xequal (cfg, klass, args [0], args [1]);
Comment thread
simonrozsival marked this conversation as resolved.
Outdated
case SN_EqualsAny: {
MonoInst *cmp_eq = emit_xcompare (cfg, klass, arg0_type, args [0], args [1]);
MonoInst *zero = emit_xzero (cfg, klass);
MonoInst *ins = emit_xequal (cfg, klass, cmp_eq, zero);
int sreg = ins->dreg;
int dreg = alloc_ireg (cfg);
MONO_EMIT_NEW_BIALU_IMM (cfg, OP_COMPARE_IMM, -1, sreg, 0);
EMIT_NEW_UNALU (cfg, ins, OP_CEQ, dreg, -1);
return ins;
}
case SN_GetElement: {
MonoClass *arg_class = mono_class_from_mono_type_internal (fsig->params [0]);
MonoType *etype = mono_class_get_context (arg_class)->class_inst->type_argv [0];
Expand Down Expand Up @@ -944,10 +964,10 @@ emit_vector64_vector128_t (MonoCompile *cfg, MonoMethod *cmethod, MonoMethodSign
return ins;
}
case SN_get_Zero: {
return emit_simd_ins (cfg, klass, OP_XZERO, -1, -1);
return emit_xzero (cfg, klass);
}
case SN_get_AllBitsSet: {
MonoInst *ins = emit_simd_ins (cfg, klass, OP_XZERO, -1, -1);
MonoInst *ins = emit_xzero (cfg, klass);
return emit_xcompare (cfg, klass, etype->type, ins, ins);
Comment thread
simonrozsival marked this conversation as resolved.
}
case SN_Equals: {
Expand Down Expand Up @@ -1112,7 +1132,7 @@ emit_sys_numerics_vector_t (MonoCompile *cfg, MonoMethod *cmethod, MonoMethodSig
return ins;
case SN_get_Zero:
g_assert (fsig->param_count == 0 && mono_metadata_type_equal (fsig->ret, type));
return emit_simd_ins (cfg, klass, OP_XZERO, -1, -1);
return emit_xzero (cfg, klass);
case SN_get_One: {
g_assert (fsig->param_count == 0 && mono_metadata_type_equal (fsig->ret, type));
MonoInst *one = NULL;
Expand Down Expand Up @@ -1141,7 +1161,7 @@ emit_sys_numerics_vector_t (MonoCompile *cfg, MonoMethod *cmethod, MonoMethodSig
}
case SN_get_AllBitsSet: {
/* Compare a zero vector with itself */
ins = emit_simd_ins (cfg, klass, OP_XZERO, -1, -1);
ins = emit_xzero (cfg, klass);
return emit_xcompare (cfg, klass, etype->type, ins, ins);
}
case SN_get_Item: {
Expand Down
1 change: 1 addition & 0 deletions src/mono/mono/mini/simd-methods.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ METHOD(CreateScalar)
METHOD(CreateScalarUnsafe)
METHOD(ConditionalSelect)
METHOD(EqualsAll)
METHOD(EqualsAny)
METHOD(GetElement)
METHOD(GetLower)
METHOD(GetUpper)
Expand Down