Minimize the build graph by deleting unnecessary references

[ViktorHofer]

Contributes to #65552

Minimizing projects' dependency graph. There are tons of unnecessary
Reference and ProjectReference items which aren't required anymore as
the referenced projects became full façade assemblies. Removing those
from a leaf's graph makes the graph smaller and therefore the project's
evaluation and build faster.

Examples of full facade projects are:

• System.Runtime.CompilerServices.Unsafe.csproj
• System.Runtime.Extensions.csproj

The changes were performed via:

• Find & Replace of:
  • <Reference Include="full-facade-assembly" />
  • <ProjectReference Include="full-facade-project" />
• Manually checking if the compiled assembly actually requires the
  defined ProjectReference/Reference items and removing them if not.

Unrelated changes that I applied in the projects that I already touched:

• In a handful of projects, adding missing primary references that were
  previously brought in transitively.
• Adding empty lines between property and/or item groups to make
  project files more readable. Most projects in src/libraries already
  follow that style.
• Moving a few Compile items into their own ItemGroup to improve
  readability of project files.

[ghost]

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

[ghost]

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Contributes to #65552

Minimizing projects' dependency graph. There are tons of unnecessary
Reference and ProjectReference items which aren't required anymore as
the referenced projects became full façade assemblies. Removing those
from a leaf's graph makes the graph smaller and therefore the project's
evaluation and build faster.

Examples of full facade projects are:

• System.Runtime.CompilerServices.Unsafe.csproj
• System.Runtime.Extensions.csproj

The changes were performed via:

• Find & Replace of:
  • <Reference Include="full-facade-assembly" />
  • <ProjectReference Include="full-facade-project" />
• Manually checking if the compiled assembly actually requires the
  defined ProjectReference/Reference items and removing them if not.

Unrelated changes that I applied in the projects that I already touched:

• In a handful of projects, adding missing primary references that were
  previously brought in transitively.
• Adding empty lines between property and/or item groups to make
  project files more readable. Most projects in src/libraries already
  follow that style.
• Moving a few Compile items into their own ItemGroup to improve
  readability of project files.

Author:	ViktorHofer
Assignees:	ViktorHofer
Labels:	area-Infrastructure-libraries
Milestone:	-

[ViktorHofer]

@tannergooding do you think the above mentioned ApiCompat error will be fixed with your recent change to use primitive types always?

[tannergooding]

This one I'm not sure is impacted. The logic I changed was only impacting Boolean itself using bool vs Boolean (and same for other primitives).

I wouldn't have expected it to also impact attribute decisions like this one. So there may still be another GenApi fix needed to ensure typeof here is allowing the keyword where possible.

[ViktorHofer]

@eerhardt I'm applying your feedback here.

[bartonjs]

Assuming it builds, LGTM.

[ViktorHofer]

Requesting feedback from a few folks as this is general clean-up / build optimization and not specific to infrastructure.

EDIT: As Jeremy already approved the PR I don't think additional reviews are needed (basically because this should be a non controversial change).

[ghost]

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Contributes to #65552

Minimizing projects' dependency graph. There are tons of unnecessary
Reference and ProjectReference items which aren't required anymore as
the referenced projects became full façade assemblies. Removing those
from a leaf's graph makes the graph smaller and therefore the project's
evaluation and build faster.

Examples of full facade projects are:

• System.Runtime.CompilerServices.Unsafe.csproj
• System.Runtime.Extensions.csproj

The changes were performed via:

• Find & Replace of:
  • <Reference Include="full-facade-assembly" />
  • <ProjectReference Include="full-facade-project" />
• Manually checking if the compiled assembly actually requires the
  defined ProjectReference/Reference items and removing them if not.

Unrelated changes that I applied in the projects that I already touched:

• In a handful of projects, adding missing primary references that were
  previously brought in transitively.
• Adding empty lines between property and/or item groups to make
  project files more readable. Most projects in src/libraries already
  follow that style.
• Moving a few Compile items into their own ItemGroup to improve
  readability of project files.

Author:	ViktorHofer
Assignees:	ViktorHofer
Labels:	area-Meta
Milestone:	-

[ViktorHofer]

Assuming it builds, LGTM.

@bartonjs that was fast 😄. And I agree that if the changes builds successfully, they should be correct.

[eerhardt]

@GrabYourPitchforks sees "delete SecureString.cs" and starts to celebrate 🥳