Merged
Conversation
… no corresponding managed method.
ghost
assigned
vargaz
requested review from
fanyang-mono and
lateralusX
and removed request for
SamMonoRT
lambdageek
reviewed
Apr 29, 2022
src/mono/mono/mini/mini-llvm.c
Outdated
Member
There was a problem hiding this comment.
one of the motivations for opaque pointer types in the LLVM docs is that it allows them to get rid of a lot of pointer-to-pointer bitcasts that are just changing the element type.
I'm guessing they probably have a pass that will remove these pretty early on.
Do you think we should try to avoid emitting them at all?
Contributor
Author
There was a problem hiding this comment.
We are still using the non-opaque mode since the opaque mode is experimental afaik in llvm 11.x. So we can remove those after switching to llvm 14.x.
lambdageek
approved these changes
Apr 29, 2022
SamMonoRT
approved these changes
Apr 29, 2022
Contributor
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fanyang-mono
approved these changes
Apr 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.