Fix Configuration Binder Test with WASM and Trimming#72485
Merged
tarekgh merged 2 commits intodotnet:mainfrom Jul 20, 2022
Merged
Fix Configuration Binder Test with WASM and Trimming#72485tarekgh merged 2 commits intodotnet:mainfrom
tarekgh merged 2 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue Detailsnull
|
tarekgh
force-pushed
the
FixConfigurationBinderTestWithWasmAndTrimming
branch
from
eb971c9 to
8e76c5c
Compare
Contributor
|
Just catching up on things; was the original test failure due to a constructor on SortedSet being trimmed for WASM? (I'm not too sure of the terminology I just used there!) |
Member
|
Correct. There are WebAssembly (WASM) test legs that fully trim the unit tests and try to run them. Since no code in the unit test was using the parameterless constructor on SortedSet, it was being trimmed causing the test to fail. |
Contributor
|
That's amazing! Clever stuff indeed. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72465