Move the CreateCastingConverter<T>() method to the base JsonConverter type.#87211
Merged
eiriktsarpalis merged 1 commit intodotnet:mainfrom Jun 7, 2023
Merged
Conversation
eiriktsarpalis
added
size-reduction
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsContributes to #87078.
|
eiriktsarpalis
requested review from
MichalStrehovsky,
eerhardt,
krwq and
layomia
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsContributes to #87078.
|
This was referenced Jun 15, 2023
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This generic virtual method was necessary back when CastingConverter was strongly typed, but since #80755 got merged this is not strictly necessary so it can be refactored to something that is more code size friendly.
Contributes to #87078.